1498579 - Permafailing browser/modules/test/browser/browser_PageActions.js | Actions in panel after adding the action when Gecko 64 merges to Beta on 2018-10-15

Status: VERIFIED FIXED

(Web Compatibility :: Tooling & Investigations, defect, P1)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Central as Beta push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c50089899295130a88f70cf7d125ebe269602e4&group_state=expanded&selectedJob=205062577

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205062577&repo=try&lineNumber=16139

06:06:04     INFO - TEST-PASS | browser/modules/test/browser/browser_PageActions.js | onShowingInPanelCallCount should be inc'ed - 1 == 1 - 
06:06:04     INFO - Buffered messages finished
06:06:04     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_PageActions.js | Actions in panel after adding the action - [{"_id":"bookmark","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).bookmark.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      browserPageActions(buttonNode).bookmark.onShowingInPanel(buttonNode);\n    }","_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":"star-button-box","_wantsIframe":null,"_wantsSubview":null,"__urlbarNodeInMarkup":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"pocket","_title":"Save Page to Pocket","_anchorIDOverride":"pocket-button","_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(window) {\n          let doc = window.document;\n\n          if (doc.getElementById(\"pocket-button-box\")) {\n            return;\n          }\n\n          let wrapper = doc.createXULElement(\"hbox\");\n          wrapper.id = \"pocket-button-box\";\n          wrapper.classList.add(\"urlbar-icon-wrapper\", \"urlbar-page-action\");\n          let animatableBox = doc.createXULElement(\"hbox\");\n          animatableBox.id = \"pocket-animatable-box\";\n          let animatableImage = doc.createXULElement(\"image\");\n          animatableImage.id = \"pocket-animatable-image\";\n          animatableImage.setAttribute(\"role\", \"presentation\");\n          let tooltip =\n            gPocketBundle.GetStringFromName(\"pocket-button.tooltiptext\");\n          animatableImage.setAttribute(\"tooltiptext\", tooltip);\n          let pocketButton = doc.createXULElement(\"image\");\n          pocketButton.id = \"pocket-button\";\n          pocketButton.classList.add(\"urlbar-icon\");\n          pocketButton.setAttribute(\"role\", \"button\");\n          pocketButton.setAttribute(\"tooltiptext\", tooltip);\n\n          wrapper.appendChild(pocketButton);\n          wrapper.appendChild(animatableBox);\n          animatableBox.appendChild(animatableImage);\n          let iconBox = doc.getElementById(\"page-action-buttons\");\n          iconBox.appendChild(wrapper);\n          wrapper.hidden = true;\n\n          wrapper.addEventListener(\"click\", event => {\n            let {BrowserPageActions} = wrapper.ownerGlobal;\n            BrowserPageActions.doCommandForAction(this, event, wrapper);\n          });\n        }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":"onIframeHidden(iframe, panel) {\n          if (iframe.getAttribute(\"itemAdded\") == \"true\") {\n            iframe.ownerGlobal.LibraryUI.triggerLibraryAnimation(\"pocket\");\n          }\n\n          if (!PocketPageAction.urlbarNode) {\n            return;\n          }\n          PocketPageAction.urlbarNode.removeAttribute(\"animate\");\n          PocketPageAction.urlbarNode.removeAttribute(\"open\");\n          delete PocketPageAction.urlbarNode;\n\n          if (iframe.getAttribute(\"itemAdded\") == \"true\") {\n            PocketPageAction.innerWindowIDsByBrowser.set(\n              PocketPageAction.pocketedBrowser,\n              PocketPageAction.pocketedBrowserInnerWindowID\n            );\n          } else {\n            PocketPageAction.innerWindowIDsByBrowser.delete(\n              PocketPageAction.pocketedBrowser\n            );\n          }\n          PocketPageAction.updateUrlbarNodeState(panel.ownerGlobal);\n          delete PocketPageAction.pocketedBrowser;\n          delete PocketPageAction.pocketedBrowserInnerWindowID;\n        }","_onIframeShowing":"onIframeShowing(iframe, panel) {\n          Pocket.onShownInPhotonPageActionPanel(panel, iframe);\n\n          let doc = panel.ownerDocument;\n          let urlbarNode = doc.getElementById(\"pocket-button-box\");\n          if (!urlbarNode || urlbarNode.hidden) {\n            return;\n          }\n\n          BrowserUtils.setToolbarButtonHeightProperty(urlbarNode);\n\n          PocketPageAction.urlbarNode = urlbarNode;\n          PocketPageAction.urlbarNode.setAttribute(\"open\", \"true\");\n          if (Services.prefs.getBoolPref(\"toolkit.cosmeticAnimations.enabled\")) {\n            PocketPageAction.urlbarNode.setAttribute(\"animate\", \"true\");\n          }\n\n          let browser = panel.ownerGlobal.gBrowser.selectedBrowser;\n          PocketPageAction.pocketedBrowser = browser;\n          PocketPageAction.pocketedBrowserInnerWindowID = browser.innerWindowID;\n        }","_onLocationChange":"onLocationChange(browserWindow) {\n          PocketPageAction.updateUrlbarNodeState(browserWindow);\n        }","_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":"pocket-button-box","_wantsIframe":true,"_wantsSubview":null,"__insertBeforeActionID":"bookmarkSeparator","__urlbarNodeInMarkup":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Save Page to Pocket","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"bookmarkSeparator","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"__isSeparator":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"copyURL","_title":"copyURL-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).copyURL\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).copyURL.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Copy Link","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"emailLink","_title":"emailLink-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).emailLink\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).emailLink.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Email Link…","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"sendToDevice","_title":"sendToDevice","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).sendToDevice\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":"onLocationChange(browserWindow) {\n      browserPageActions(browserWindow).sendToDevice.onLocationChange();\n    }","_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":"onSubviewPlaced(panelViewNode) {\n      browserPageActions(panelViewNode).sendToDevice\n        .onSubviewPlaced(panelViewNode);\n    }","_onSubviewShowing":"onSubviewShowing(panelViewNode) {\n      browserPageActions(panelViewNode).sendToDevice\n        .onShowingSubview(panelViewNode);\n    }","_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"sendToDevice","tooltip":null,"wantsSubview":true},"_windowProps":{}},{"_id":"shareURL","_title":"shareURL-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).shareURL\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      browserPageActions(buttonNode).shareURL.onShowingInPanel(buttonNode);\n    }","_onSubviewPlaced":null,"_onSubviewShowing":"onSubviewShowing(panelViewNode) {\n        browserPageActions(panelViewNode).shareURL\n          .onShowingSubview(panelViewNode);\n    }","_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Share","tooltip":null,"wantsSubview":true},"_windowProps":{}},{"_id":"builtInSeparator","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"__isSeparator":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"webcompat-reporter_mozilla_org","_title":"Report Site Issue…","_anchorIDOverride":null,"_disabled":true,"_extensionID":"[e-mail]","_iconURL":{"19":"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg"},"_labelForHistogram":"webcompat","_onBeforePlacedInWindow":"browserWindow => {\n          if (this.extension.hasPermission(\"menus\") ||\n              this.extension.hasPermission(\"contextMenus\")) {\n            browserWindow.document.addEventListener(\"popupshowing\", this);\n          }\n        }","_onCommand":"(event, buttonNode) => {\n          this.handleClick(event.target.ownerGlobal);\n        }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":"browserWindow => {\n          browserWindow.document.removeEventListener(\"popupshowing\", this);\n        }","_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":true,"iconURL":{"19":"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg"},"iconProps":{"--pageAction-image-16px":"url(\"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg\")","--pageAction-image-32px":"url(\"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg\")"},"title":"Report Site Issue…","tooltip":"Report a site compatibility issue","wantsSubview":null},"_windowProps":{}},{"_id":"test-simple","_title":"Test simple","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":"chrome://browser/skin/mail.svg","_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":"onCommand(event, buttonNode) {\n      onCommandCallCount++;\n      Assert.ok(event, \"event should be non-null: \" + event);\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, onCommandExpectedButtonID, \"buttonNode.id\");\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":"onPlacedInPanel(buttonNode) {\n      onPlacedInPanelCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, panelButtonID, \"buttonNode.id\");\n    }","_onPlacedInUrlbar":"onPlacedInUrlbar(buttonNode) {\n      onPlacedInUrlbarCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, urlbarButtonID, \"buttonNode.id\");\n    }","_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      onShowingInPanelCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, panelButtonID, \"buttonNode.id\");\n    }","_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":"Test simple tooltip","_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":"chrome://browser/skin/mail.svg","iconProps":{"--pageAction-image-16px":"url(\"chrome://browser/skin/mail.svg\")","--pageAction-image-32px":"url(\"chrome://browser/skin/mail.svg\")"},"title":"Test simple","tooltip":"Test simple tooltip","wantsSubview":null},"_windowProps":{}}] deepEqual [{"_id":"bookmark","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).bookmark.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      browserPageActions(buttonNode).bookmark.onShowingInPanel(buttonNode);\n    }","_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":"star-button-box","_wantsIframe":null,"_wantsSubview":null,"__urlbarNodeInMarkup":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"pocket","_title":"Save Page to Pocket","_anchorIDOverride":"pocket-button","_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(window) {\n          let doc = window.document;\n\n          if (doc.getElementById(\"pocket-button-box\")) {\n            return;\n          }\n\n          let wrapper = doc.createXULElement(\"hbox\");\n          wrapper.id = \"pocket-button-box\";\n          wrapper.classList.add(\"urlbar-icon-wrapper\", \"urlbar-page-action\");\n          let animatableBox = doc.createXULElement(\"hbox\");\n          animatableBox.id = \"pocket-animatable-box\";\n          let animatableImage = doc.createXULElement(\"image\");\n          animatableImage.id = \"pocket-animatable-image\";\n          animatableImage.setAttribute(\"role\", \"presentation\");\n          let tooltip =\n            gPocketBundle.GetStringFromName(\"pocket-button.tooltiptext\");\n          animatableImage.setAttribute(\"tooltiptext\", tooltip);\n          let pocketButton = doc.createXULElement(\"image\");\n          pocketButton.id = \"pocket-button\";\n          pocketButton.classList.add(\"urlbar-icon\");\n          pocketButton.setAttribute(\"role\", \"button\");\n          pocketButton.setAttribute(\"tooltiptext\", tooltip);\n\n          wrapper.appendChild(pocketButton);\n          wrapper.appendChild(animatableBox);\n          animatableBox.appendChild(animatableImage);\n          let iconBox = doc.getElementById(\"page-action-buttons\");\n          iconBox.appendChild(wrapper);\n          wrapper.hidden = true;\n\n          wrapper.addEventListener(\"click\", event => {\n            let {BrowserPageActions} = wrapper.ownerGlobal;\n            BrowserPageActions.doCommandForAction(this, event, wrapper);\n          });\n        }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":"onIframeHidden(iframe, panel) {\n          if (iframe.getAttribute(\"itemAdded\") == \"true\") {\n            iframe.ownerGlobal.LibraryUI.triggerLibraryAnimation(\"pocket\");\n          }\n\n          if (!PocketPageAction.urlbarNode) {\n            return;\n          }\n          PocketPageAction.urlbarNode.removeAttribute(\"animate\");\n          PocketPageAction.urlbarNode.removeAttribute(\"open\");\n          delete PocketPageAction.urlbarNode;\n\n          if (iframe.getAttribute(\"itemAdded\") == \"true\") {\n            PocketPageAction.innerWindowIDsByBrowser.set(\n              PocketPageAction.pocketedBrowser,\n              PocketPageAction.pocketedBrowserInnerWindowID\n            );\n          } else {\n            PocketPageAction.innerWindowIDsByBrowser.delete(\n              PocketPageAction.pocketedBrowser\n            );\n          }\n          PocketPageAction.updateUrlbarNodeState(panel.ownerGlobal);\n          delete PocketPageAction.pocketedBrowser;\n          delete PocketPageAction.pocketedBrowserInnerWindowID;\n        }","_onIframeShowing":"onIframeShowing(iframe, panel) {\n          Pocket.onShownInPhotonPageActionPanel(panel, iframe);\n\n          let doc = panel.ownerDocument;\n          let urlbarNode = doc.getElementById(\"pocket-button-box\");\n          if (!urlbarNode || urlbarNode.hidden) {\n            return;\n          }\n\n          BrowserUtils.setToolbarButtonHeightProperty(urlbarNode);\n\n          PocketPageAction.urlbarNode = urlbarNode;\n          PocketPageAction.urlbarNode.setAttribute(\"open\", \"true\");\n          if (Services.prefs.getBoolPref(\"toolkit.cosmeticAnimations.enabled\")) {\n            PocketPageAction.urlbarNode.setAttribute(\"animate\", \"true\");\n          }\n\n          let browser = panel.ownerGlobal.gBrowser.selectedBrowser;\n          PocketPageAction.pocketedBrowser = browser;\n          PocketPageAction.pocketedBrowserInnerWindowID = browser.innerWindowID;\n        }","_onLocationChange":"onLocationChange(browserWindow) {\n          PocketPageAction.updateUrlbarNodeState(browserWindow);\n        }","_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":"pocket-button-box","_wantsIframe":true,"_wantsSubview":null,"__insertBeforeActionID":"bookmarkSeparator","__urlbarNodeInMarkup":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Save Page to Pocket","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"bookmarkSeparator","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"__isSeparator":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"copyURL","_title":"copyURL-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).copyURL\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).copyURL.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Copy Link","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"emailLink","_title":"emailLink-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).emailLink\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":"onCommand(event, buttonNode) {\n      browserPageActions(buttonNode).emailLink.onCommand(event, buttonNode);\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Email Link…","tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"sendToDevice","_title":"sendToDevice","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).sendToDevice\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":"onLocationChange(browserWindow) {\n      browserPageActions(browserWindow).sendToDevice.onLocationChange();\n    }","_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":"onSubviewPlaced(panelViewNode) {\n      browserPageActions(panelViewNode).sendToDevice\n        .onSubviewPlaced(panelViewNode);\n    }","_onSubviewShowing":"onSubviewShowing(panelViewNode) {\n      browserPageActions(panelViewNode).sendToDevice\n        .onShowingSubview(panelViewNode);\n    }","_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"sendToDevice","tooltip":null,"wantsSubview":true},"_windowProps":{}},{"_id":"shareURL","_title":"shareURL-title","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":"onBeforePlacedInWindow(browserWindow) {\n      browserPageActions(browserWindow).shareURL\n        .onBeforePlacedInWindow(browserWindow);\n    }","_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      browserPageActions(buttonNode).shareURL.onShowingInPanel(buttonNode);\n    }","_onSubviewPlaced":null,"_onSubviewShowing":"onSubviewShowing(panelViewNode) {\n        browserPageActions(panelViewNode).shareURL\n          .onShowingSubview(panelViewNode);\n    }","_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":"Share","tooltip":null,"wantsSubview":true},"_windowProps":{}},{"_id":"builtInSeparator","_title":null,"_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":null,"_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":null,"_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":null,"_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"__isSeparator":true,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":null,"iconProps":{"--pageAction-image-16px":null,"--pageAction-image-32px":null},"title":null,"tooltip":null,"wantsSubview":null},"_windowProps":{}},{"_id":"test-simple","_title":"Test simple","_anchorIDOverride":null,"_disabled":null,"_extensionID":null,"_iconURL":"chrome://browser/skin/mail.svg","_labelForHistogram":null,"_onBeforePlacedInWindow":null,"_onCommand":"onCommand(event, buttonNode) {\n      onCommandCallCount++;\n      Assert.ok(event, \"event should be non-null: \" + event);\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, onCommandExpectedButtonID, \"buttonNode.id\");\n    }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":"onPlacedInPanel(buttonNode) {\n      onPlacedInPanelCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, panelButtonID, \"buttonNode.id\");\n    }","_onPlacedInUrlbar":"onPlacedInUrlbar(buttonNode) {\n      onPlacedInUrlbarCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, urlbarButtonID, \"buttonNode.id\");\n    }","_onRemovedFromWindow":null,"_onShowingInPanel":"onShowingInPanel(buttonNode) {\n      onShowingInPanelCallCount++;\n      Assert.ok(buttonNode, \"buttonNode should be non-null: \" + buttonNode);\n      Assert.equal(buttonNode.id, panelButtonID, \"buttonNode.id\");\n    }","_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":null,"_tooltip":"Test simple tooltip","_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":null,"iconURL":"chrome://browser/skin/mail.svg","iconProps":{"--pageAction-image-16px":"url(\"chrome://browser/skin/mail.svg\")","--pageAction-image-32px":"url(\"chrome://browser/skin/mail.svg\")"},"title":"Test simple","tooltip":"Test simple tooltip","wantsSubview":null},"_windowProps":{}},{"_id":"webcompat-reporter_mozilla_org","_title":"Report Site Issue…","_anchorIDOverride":null,"_disabled":true,"_extensionID":"[e-mail]","_iconURL":{"19":"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg"},"_labelForHistogram":"webcompat","_onBeforePlacedInWindow":"browserWindow => {\n          if (this.extension.hasPermission(\"menus\") ||\n              this.extension.hasPermission(\"contextMenus\")) {\n            browserWindow.document.addEventListener(\"popupshowing\", this);\n          }\n        }","_onCommand":"(event, buttonNode) => {\n          this.handleClick(event.target.ownerGlobal);\n        }","_onIframeHiding":null,"_onIframeHidden":null,"_onIframeShowing":null,"_onLocationChange":null,"_onPlacedInPanel":null,"_onPlacedInUrlbar":null,"_onRemovedFromWindow":"browserWindow => {\n          browserWindow.document.removeEventListener(\"popupshowing\", this);\n        }","_onShowingInPanel":null,"_onSubviewPlaced":null,"_onSubviewShowing":null,"_pinnedToUrlbar":true,"_tooltip":null,"_urlbarIDOverride":null,"_wantsIframe":null,"_wantsSubview":null,"_iconProperties":{},"_globalProps":{"disabled":true,"iconURL":{"19":"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg"},"iconProps":{"--pageAction-image-16px":"url(\"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg\")","--pageAction-image-32px":"url(\"moz-extension://ccc731c6-ba5a-d347-93c5-884170880109/icons/lightbulb.svg\")"},"title":"Report Site Issue…","tooltip":"Report a site compatibility issue","wantsSubview":null},"_windowProps":{}}] - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_PageActions.js :: simple :: line 152
06:06:04     INFO - Stack trace:
06:06:04     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_PageActions.js:simple:152

Might be a regression from Bug 1451485?

Comment 1

[Mike Taylor [:miketaylr]]

Not sure we understand why this would fail on beta just yet, but worse case scenario we can just disable the addon before the test runs... and figure it out later.

Comment 2

[Thomas Wisniewski [:twisniewski]]

This is happening because system addons are currently loaded, and then a bit of code added to nsBrowserGlue is meant to check whether to disable the webcompat reporter:

https://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js#1451

Unfortunately, if the pref is already false (as it is on beta) the observer there will never be informed, and so the addon will stay active, when it should be disabled. I'm doing a try-run of a simple fix for this:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f7f609e78600a1a6a26d7e9b2692a7c321c52c1

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1498579 - Ensure the webcompat report addon is disabled upon load, if extensions.webcompat-reporter.enabled=false; r?aswan

Ensure the webcompat report addon is disabled upon load, if extensions.webcompat-reporter.enabled=false

Comment 4

[Thomas Wisniewski [:twisniewski]]

The try run showed some unfamiliar bustage, but I did another one without my patch being activated which shows the same failures so far, so I'd be surprised if they're related: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0691f2bf2bf83467225ef8074e8d33222b99f45e&selectedJob=205196637

As such aswan and I have decided to try checking this patch in to avoid the permafailure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6beac5dc4899
Ensure the webcompat report addon is disabled upon load, if extensions.webcompat-reporter.enabled=false; r=aswan

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6beac5dc4899

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception,retry,usercancel,runnable&revision=3157d00d6962b95cdc5d13199556e35dd9e6e641