Closed Bug 1498586 Opened Last year Closed Last year

clang-format: Ignore some formatting

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox-esr60 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Too hard/impossible for the tool to format correctly these structs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7807742373e1
Add clang-format off to avoid the reformatting of the data structures r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/7807742373e1
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee: nobody → sledru
Comment on attachment 9030737 [details] [diff] [review]
ESR patch

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 64

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary.  Has also been tested in Nightly for a couple of months or so...

String or UUID changes made by this patch: None
Attachment #9030737 - Flags: approval-mozilla-release? → approval-mozilla-esr60?
Attached patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Please see comment 5

User impact if declined: 

Fix Landed on Version: 

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String or UUID changes made by this patch:
Attachment #9030737 - Attachment is obsolete: true
Attachment #9030737 - Flags: approval-mozilla-esr60?
Attachment #9030980 - Flags: approval-mozilla-esr60?
Comment on attachment 9030980 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030980 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.