1498618 - Never apply clang-format on code in {{{ check_macroassembler_style

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Because the python is expecting a very specific programming patterns and it isn't easy to update it.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1498618 - Never apply clang-format on code in {{{ check_macroassembler_style r?nbp

Comment 2

[Sylvestre Ledru [:Sylvestre]]

The python script works with any changes in js/src/.clang-format

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7127bf67c3b9
Never apply clang-format on code in {{{ check_macroassembler_style r=nbp

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7127bf67c3b9

Comment 5

[(no longer active)]

Attachment: ESR patch

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 64

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary.  Has also been tested in Nightly for a couple of months or so...

String or UUID changes made by this patch: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9030738 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.

Comment 7

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/d6e9e6ff586f