Closed Bug 1498618 Opened 5 years ago Closed 5 years ago

Never apply clang-format on code in {{{ check_macroassembler_style

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1498618 - Never apply clang-format on code in {{{ check_macroassembler_style r?nbp
46 bytes, text/x-phabricator-request
Details | Review
ESR patch
13.20 KB, patch
lizzard
: approval-mozilla-esr60+
Details | Diff | Splinter Review 
Because the python is expecting a very specific programming patterns and it isn't easy to update it.
The python script works with any changes in js/src/.clang-format
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7127bf67c3b9
Never apply clang-format on code in {{{ check_macroassembler_style r=nbp
Depends on: 1499323
https://hg.mozilla.org/mozilla-central/rev/7127bf67c3b9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Attached patch ESR patch — — Splinter Review 
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 64

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary.  Has also been tested in Nightly for a couple of months or so...

String or UUID changes made by this patch: None
Attachment #9030738 - Flags: approval-mozilla-esr60?
Attachment #9030738 - Attachment is patch: true
Attachment #9030738 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 9030738 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030738 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.