Closed Bug 1498662 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 13485 - [css-properties-values-api] Support StylePropertyMap.append.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13485 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13485
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Support StylePropertyMap.append.
>  
>  This CL makes it possible to append values to list-valued properties.
>  
>  To do this, we must produce a CSSStyleValueVector which holds the final
>  value produced by the append (i.e. the concatenation of the existing
>  values and the incoming values). Then (like for StylePropertyMap.set),
>  a CSSVariableReferenceValue with equivalent tokens is created from that
>  vector.
>  
>  Bonus: Fix names of some tests to make it easier to read the output.
>  
>  R=chrishtr@chromium.org
>  
>  Bug: 641877
>  Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
>  Reviewed-on: https://chromium-review.googlesource.com/c/1270967
>  Commit-Queue: Anders Ruud \<andruud@chromium.org>
>  Reviewed-by: Chris Harrelson \<chrishtr@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#599177}
>
PR 13485 applied with additional changes from upstream: e8a20c396e2ed7b7b8b2cacd3128f959e710a243
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 20 subtests
FAIL   : 20
ERROR  : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5802a4b65562
[wpt PR 13485] - [css-properties-values-api] Support StylePropertyMap.append., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bc90d61ddfd
[wpt PR 13485] - [css-properties-values-api] Support StylePropertyMap.append., a=testonly
https://hg.mozilla.org/mozilla-central/rev/5bc90d61ddfd
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.