Closed Bug 1498679 Opened Last year Closed Last year

Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail| wpt/setSinkId.html | setSinkId fails with NotFoundError on made up deviceid - assert_unreached: Should have rejected: undefined Reached unreachable code

Categories

(Core :: WebRTC, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: achronop)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=205134023&repo=mozilla-central

https://queue.taskcluster.net/v1/task/T7Q9J1e2TWG2OYX7j5W0DQ/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-12T18:31:20.721Z] 18:31:20     INFO - TEST-PASS | dom/media/tests/mochitest/test_setSinkId.html | Sink device is set for 2nd time for the same id: Ogo/6tq5xMOf14QpZ51jmnxMgTLKYHjzJTQavzKQk1Y= 
[task 2018-10-12T18:31:20.723Z] 18:31:20     INFO - Buffered messages finished
[task 2018-10-12T18:31:20.724Z] 18:31:20     INFO - TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail 
[task 2018-10-12T18:31:20.725Z] 18:31:20     INFO -     @dom/media/tests/mochitest/test_setSinkId.html:45:7
[task 2018-10-12T18:31:20.727Z] 18:31:20     INFO -     async*runTestWhenReady/<@dom/media/tests/mochitest/head.js:471:41
[task 2018-10-12T18:31:20.728Z] 18:31:20     INFO -     promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:471:10
[task 2018-10-12T18:31:20.729Z] 18:31:20     INFO -     runTest/<@dom/media/tests/mochitest/mediaStreamPlayback.js:248:15
[task 2018-10-12T18:31:20.730Z] 18:31:20     INFO -     promise callback*runTest@dom/media/tests/mochitest/mediaStreamPlayback.js:247:31
[task 2018-10-12T18:31:20.731Z] 18:31:20     INFO -     @dom/media/tests/mochitest/test_setSinkId.html:20:3
This fail was introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=934425
:achronop could you please take a look?
Flags: needinfo?(achronop)
See Also: → 934425
Summary: Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail → Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail | setSinkId fails with NotFoundError on made up deviceid - assert_unreached: Should have rejected: undefined Reached unreachable code
Summary: Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail | setSinkId fails with NotFoundError on made up deviceid - assert_unreached: Should have rejected: undefined Reached unreachable code → Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail| wpt/setSinkId.html | setSinkId fails with NotFoundError on made up deviceid - assert_unreached: Should have rejected: undefined Reached unreachable code
I am able to reproduce the failure with the fiddle in [1] using the Linux x64 CCov debug build from the last try run. When the invalid sinkId is being set, the MediaManager::GetSinkId() is exiting unexpectedly from [2]. I assume that the `aDeviceId.IsEmpty()` appears to be true thus I am getting the error. In the caller of that method, HTMLMediaElement::SetSinkId(), the sinkId variable (which corresponds to aDeviceId) is moved [3] and the argument of the method is captured by reference. I will try removing the move and the reference to verify or not my theory.

[1] https://jsfiddle.net/achronop/fd8ehL96/
[2] https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/dom/media/MediaManager.cpp#3455
[3] https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/dom/html/HTMLMediaElement.cpp#8336
Flags: needinfo?(achronop)
Assignee: nobody → achronop
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db19bf2d6479
Stop moving variable to fix Linux64 debug coverage build. r=pehrsons
https://hg.mozilla.org/mozilla-central/rev/db19bf2d6479
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.