1498679 - Perma tier2 dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail| wpt/setSinkId.html | setSinkId fails with NotFoundError on made up deviceid - assert_unreached: Should have rejected: undefined Reached unreachable code

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=205134023&repo=mozilla-central

https://queue.taskcluster.net/v1/task/T7Q9J1e2TWG2OYX7j5W0DQ/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-12T18:31:20.721Z] 18:31:20     INFO - TEST-PASS | dom/media/tests/mochitest/test_setSinkId.html | Sink device is set for 2nd time for the same id: Ogo/6tq5xMOf14QpZ51jmnxMgTLKYHjzJTQavzKQk1Y= 
[task 2018-10-12T18:31:20.723Z] 18:31:20     INFO - Buffered messages finished
[task 2018-10-12T18:31:20.724Z] 18:31:20     INFO - TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_setSinkId.html | Never enter here, this must fail 
[task 2018-10-12T18:31:20.725Z] 18:31:20     INFO -     @dom/media/tests/mochitest/test_setSinkId.html:45:7
[task 2018-10-12T18:31:20.727Z] 18:31:20     INFO -     async*runTestWhenReady/<@dom/media/tests/mochitest/head.js:471:41
[task 2018-10-12T18:31:20.728Z] 18:31:20     INFO -     promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:471:10
[task 2018-10-12T18:31:20.729Z] 18:31:20     INFO -     runTest/<@dom/media/tests/mochitest/mediaStreamPlayback.js:248:15
[task 2018-10-12T18:31:20.730Z] 18:31:20     INFO -     promise callback*runTest@dom/media/tests/mochitest/mediaStreamPlayback.js:247:31
[task 2018-10-12T18:31:20.731Z] 18:31:20     INFO -     @dom/media/tests/mochitest/test_setSinkId.html:20:3

Comment 1

[Cristina Coroiu [:ccoroiu]]

This fail was introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=934425
:achronop could you please take a look?

Comment 2

[Cristina Coroiu [:ccoroiu]]

Also wpt failed: https://treeherder.mozilla.org/logviewer.html#?job_id=205142124&repo=mozilla-central&lineNumber=834

Comment 3

[Intermittent Failures Robot]

20 failures in 515 pushes (0.039 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 20

Platform breakdown:
* windows10-64-msvc: 1
* linux64-ccov: 12
* windows7-32-msvc: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-12&endday=2018-10-12&tree=all

Comment 4

[Intermittent Failures Robot]

43 failures in 2740 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #37 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 2
* mozilla-central: 41

Platform breakdown:
* linux64-ccov: 33
* windows10-64-msvc: 2
* windows7-32-msvc: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-08&endday=2018-10-14&tree=all

Comment 5

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f79ae5bfd8e0dace324cb5500a9056fea44e269

Comment 6

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b98c49ac94197158d1e6188c333c84e4acba1281

Comment 7

[Intermittent Failures Robot]

19 failures in 558 pushes (0.034 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 19

Platform breakdown:
* linux64-ccov: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-17&endday=2018-10-17&tree=all

Comment 8

[Alex Chronopoulos [:achronop]]

I am able to reproduce the failure with the fiddle in [1] using the Linux x64 CCov debug build from the last try run. When the invalid sinkId is being set, the MediaManager::GetSinkId() is exiting unexpectedly from [2]. I assume that the `aDeviceId.IsEmpty()` appears to be true thus I am getting the error. In the caller of that method, HTMLMediaElement::SetSinkId(), the sinkId variable (which corresponds to aDeviceId) is moved [3] and the argument of the method is captured by reference. I will try removing the move and the reference to verify or not my theory.

[1] https://jsfiddle.net/achronop/fd8ehL96/
[2] https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/dom/media/MediaManager.cpp#3455
[3] https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/dom/html/HTMLMediaElement.cpp#8336

Comment 9

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=230fe36983a5076e046437ed8089155651c99086

Comment 10

[Intermittent Failures Robot]

16 failures in 494 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 16

Platform breakdown:
* linux64-ccov: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-18&endday=2018-10-18&tree=all

Comment 11

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e763b6bb58bd315a8d1d05e3f629fc2e39c54cd9

Comment 12

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1498679 - Stop moving variable to fix Linux64 debug coverage build. r?pehrsons

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db19bf2d6479
Stop moving variable to fix Linux64 debug coverage build. r=pehrsons

Comment 14

[Intermittent Failures Robot]

16 failures in 501 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 16

Platform breakdown:
* linux64-ccov: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-19&endday=2018-10-19&tree=all

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/db19bf2d6479

Comment 16

[Intermittent Failures Robot]

75 failures in 2759 pushes (0.027 failures/push) were associated with this bug in the last 7 days.

This is the #26 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-central: 75

Platform breakdown:
* linux64-ccov: 75

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498679&startday=2018-10-15&endday=2018-10-21&tree=all