Closed Bug 1498687 Opened Last year Closed Last year

Make webcompat-reporter WebExtension load about:blank in the reporter tab, instead of about:newtab

Categories

(Web Compatibility :: Tooling & Investigations, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

This helps avoid a potential process flip when bug 1472212 lands, which means we can keep the browser_report_site_issue.js test simple. It's also less overhead to just load about:blank, theoretically, since we don't have to fire up the RemotePages stuff that about:newtab relies on.
Assignee: nobody → mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/620be2ce2c8c
Make webcompat-reporter WebExtension load about:blank instead of about:newtab in the reporter tab. r=twisniewski
Backed out changeset 620be2ce2c8c (Bug 1498687) for browser-chrome failures at browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&selectedJob=205161397&revision=620be2ce2c8c8f346f4fa30a167e7c6afd995fd1

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205157729&repo=autoland&lineNumber=3650

Backout link: https://hg.mozilla.org/integration/autoland/rev/7571ffba8492b3d03a40c17368ebc1fb0921f10c

[task 2018-10-12T20:46:59.078Z] 20:46:59     INFO - TEST-START | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js
[task 2018-10-12T20:49:59.110Z] 20:49:59     INFO - TEST-INFO | started process screentopng
[task 2018-10-12T20:49:59.721Z] 20:49:59     INFO - TEST-INFO | screentopng: exit 0
[task 2018-10-12T20:49:59.723Z] 20:49:59     INFO - Buffered messages logged at 20:46:59
[task 2018-10-12T20:49:59.723Z] 20:49:59     INFO - Entering test bound test_opened_page
[task 2018-10-12T20:49:59.724Z] 20:49:59     INFO - Waiting for main page action button to have non-0 size
[task 2018-10-12T20:49:59.725Z] 20:49:59     INFO - Waiting for main page action panel to be open
[task 2018-10-12T20:49:59.725Z] 20:49:59     INFO - Buffered messages logged at 20:47:00
[task 2018-10-12T20:49:59.727Z] 20:49:59     INFO - promisePageActionViewChildrenVisible waiting for a child node to be visible
[task 2018-10-12T20:49:59.728Z] 20:49:59     INFO - Console message: Utils: Failed to deserialize principal_b64 '[xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable)]' [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsISerializationHelper.deserializeObject]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: deserializePrincipal :: line 137"  data: no]
[task 2018-10-12T20:49:59.728Z] 20:49:59     INFO - Buffered messages logged at 20:48:29
[task 2018-10-12T20:49:59.730Z] 20:49:59     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2018-10-12T20:49:59.734Z] 20:49:59     INFO - Buffered messages finished
[task 2018-10-12T20:49:59.736Z] 20:49:59     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js | Test timed out - 
[task 2018-10-12T20:49:59.738Z] 20:49:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-12T20:49:59.740Z] 20:49:59     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js | A promise chain failed to handle a rejection: Missing host permission for the tab - stack: Async*@moz-extension://13aa9acb-9202-472d-86c1-e1d645040dee/background.js:18:1
[task 2018-10-12T20:49:59.746Z] 20:49:59     INFO - Rejection date: Fri Oct 12 2018 20:47:01 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
[task 2018-10-12T20:49:59.747Z] 20:49:59     INFO - Stack trace:
[task 2018-10-12T20:49:59.748Z] 20:49:59     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
[task 2018-10-12T20:49:59.749Z] 20:49:59     INFO - chrome://mochikit/content/browser-test.js:nextTest:735
[task 2018-10-12T20:49:59.750Z] 20:49:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1190
[task 2018-10-12T20:49:59.750Z] 20:49:59     INFO - setTimeout handler*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest_setTimeoutShim:676
[task 2018-10-12T20:49:59.751Z] 20:49:59     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1168
[task 2018-10-12T20:49:59.752Z] 20:49:59     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1152
[task 2018-10-12T20:49:59.753Z] 20:49:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-10-12T20:49:59.754Z] 20:49:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-10-12T20:49:59.757Z] 20:49:59     INFO - GECKO(4037) | MEMORY STAT | vsize 20973977MB | residentFast 1046MB
[task 2018-10-12T20:49:59.758Z] 20:49:59     INFO - TEST-OK | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js | took 180175ms
[task 2018-10-12T20:49:59.759Z] 20:49:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-12T20:49:59.760Z] 20:49:59     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js | Found a tab after previous test timed out: http://localhost:37562/new - 
[task 2018-10-12T20:49:59.761Z] 20:49:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-12T20:49:59.763Z] 20:49:59     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js | Found a tab after previous test timed out: http://example.com/browser/browser/extensions/webcompat-reporter/test/browser/test.html - 
[task 2018-10-12T20:49:59.767Z] 20:49:59     INFO - checking window state
Flags: needinfo?(mconley)
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9626e5c3b4a4
Backed out changeset 620be2ce2c8c for browser-chrome failures at browser/extensions/webcompat-reporter/test/browser/browser_report_site_issue.js
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/942ccac42c5e
Make webcompat-reporter WebExtension load about:blank instead of about:newtab in the reporter tab. r=twisniewski
https://hg.mozilla.org/mozilla-central/rev/942ccac42c5e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.