1498720 - Ensure that we revoke a subframe's storage access when it is removed from the DOM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[(no longer active)]

From https://github.com/whatwg/html/issues/3338:

Access Removal

Storage access is granted for the life of the document and as long as the document's frame is attached to the DOM. This means:

    Access is removed when the sub frame is detached from the DOM.

Comment 1

[(no longer active)]

I tried hard to write a test for this case, but didn't really succeed.  The reason why this is hard is that once the iframe moves in the DOM it's impossible to communicate with it any longer due to the fact that the wrappers for it get replaced with the dead object wrapper in the parent page's compartment.  I couldn't find a way to get the test to work, so I will submit the patch here without a test.

It is hopefully trivial to see how we don't have any code path that currently does this, and how this patch fixes the bug.

Comment 2

[(no longer active)]

Attachment: Bug 1498720 - Ensure that we revoke a subframe's storage access when it is removed from the DOM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb057b527690
Ensure that we revoke a subframe's storage access when it is removed from the DOM r=baku

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb057b527690