Closed Bug 1498720 Opened Last year Closed Last year
Ensure that we revoke a subframe's storage access when it is removed from the DOM
46 bytes, text/x-phabricator-request
|Details | Review|
From https://github.com/whatwg/html/issues/3338: Access Removal Storage access is granted for the life of the document and as long as the document's frame is attached to the DOM. This means: Access is removed when the sub frame is detached from the DOM.
I tried hard to write a test for this case, but didn't really succeed. The reason why this is hard is that once the iframe moves in the DOM it's impossible to communicate with it any longer due to the fact that the wrappers for it get replaced with the dead object wrapper in the parent page's compartment. I couldn't find a way to get the test to work, so I will submit the patch here without a test. It is hopefully trivial to see how we don't have any code path that currently does this, and how this patch fixes the bug.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bb057b527690 Ensure that we revoke a subframe's storage access when it is removed from the DOM r=baku
You need to log in before you can comment on or make changes to this bug.