1498734 - Always compute angle values to degrees.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:

> All <angle> units are compatible, and deg is their canonical unit.

And also other implementations (Blink always serializes angles as degrees in computed style for example).

Also allows us to get rid of quite a bit of code, and makes computed angle value representation just a number, which is nice.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1498734 - Always compute angle values to degrees.

This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:

> All <angle> units are compatible, and deg is their canonical unit.

And also other implementations (Blink always serializes angles as degrees in
computed style for example).

Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

It also removes one of my oldest FIXMEs in the codebase ;)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7584ce8674c2
Always compute angle values to degrees. r=xidorn

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebaf166c5731
remove unneeded cast. r=me

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7584ce8674c2
https://hg.mozilla.org/mozilla-central/rev/ebaf166c5731

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13500 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13500
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Tt_uM_-GSQiMLc4qX5upAQ)

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged