149887 - content between IFRAME - /IFRAME displayed

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Chris Apers]

As given in the W3C spec. for IFRAME :

"The information to be inserted inline is designated by the src attribute of 
this element. The contents of the IFRAME element, on the other hand, should 
only be displayed by user agents that do not support frames or are configured 
not to display frames."

http://www.w3.org/TR/REC-html40/present/frames.html

bug with Mozilla Build ID: 2002053012 and lower (also with NS6)
Check the given URL for example.

Comment 1

[John Keiser (jkeiser)]

This is because the IFRAME is never *parsed* as though it has contents, I
believe.  I also believe that fixing it so that it did would break nearly every
site in the world that uses IFRAMEs because they do not close the tag explicitly
and therefore everything after the <IFRAME> would get displayed.

Also, please to not be setting milestone.  Milestone is for the *developer* to
say when he is getting it done.  Just ask in the bug if we can get it done by
Mozilla 1.0 (which is already released, BTW, so we cannot by definition).

Comment 2

[Boris Zbarsky [:bzbarsky]]

we aren't displaying the content here... We _are_ loading the scripts in
question.  We have to.  Consider the (perfectly valid, as far as I can tell)
markup:

  <iframe src="foo">
    Invisible content
  <script>
    document.write("<\/iframe>");
  </script>
  Visible content.

Comment 3

[harishd]

Attachment: Further reduced test case

Comment 4

[harishd]

Boris: The problem is that the script inside iframe is evaluated! ( refer to my
testcase ). It's a bug.

Comment 5

[harishd]

Boris: Ignore my previous last comment.

Comment 6

[Chris Apers]

AS i saied you can check this URL :

http://62.210.139.131/oas/test.html

Comment 7

[harishd]

Attachment: patch v1.0 [ Needs testing ]

Comment 8

[harishd]

Attachment: patch v1.1

Handling IFRAME similar to NOFRAMES

Comment 9

[harishd]

btw, parser regression test PASSED.

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 107957 [details] [diff] [review]
patch v1.1

You should probably add comments to the code where it talks about noframes and
mention iframe there as well, like in CNavDTD.

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 107957 [details] [diff] [review]
patch v1.1

sr=jst

Comment 12

[harishd]

Fix landed.

Comment 13

[Andrew Schultz]

checkin for this bug caused bug 184029, which is a hang that could potentially
hit many of the sites that use generated/nested iframes (for ad banners, mainly :()

Comment 14

[harishd]

Andrew: I'm planning on backing out this patch. 

Comment 15

[harishd]

Backed out the patch to address the issue raised in bug 184029. Reopening the
bug to reinvestigate.

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed (probably by the checkin to bug 88952) marking as such.