1498897 - Update webrender to 98d507003c07c003ef0e0297dc4d29ee896a5868

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Darkspirit]

+++ This bug was initially created as a clone of Bug #1498650 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a3374ea2e5205a9d8c901d5b0c0c443677ecccc

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd4c433b0e50
Update webrender to commit 98d507003c07c003ef0e0297dc4d29ee896a5868

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bd4c433b0e50

Comment 4

[Ionuț Goldan [:igoldan]]

AWSY improvements noticed! \o/

== Change summary for alert #16888 (as of Tue, 16 Oct 2018 16:53:51 GMT) ==

Improvements:

  6%  Heap Unclassified linux64-qr opt stylo     290,934,225.35 -> 274,569,644.29
  3%  Explicit Memory linux64-qr opt stylo       566,560,640.92 -> 552,296,146.98

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16888

Comment 5

[Bobby Holley (:bholley)]

Interesting - the only thing significant in that sync is [1]. There's no corresponding drop on windows, and it's a 15MB drop in unclassified heap memory, so my best guess is that we're somehow eliminating a heap-allocation in the linux driver. Glenn, is that plausible?

[1] https://github.com/servo/webrender/pull/3197

Comment 6

[Glenn Watson [:gw]]

I would be surprised if that change resulted in a memory reduction. It's possible, but unlikely. What were the other changes?

Comment 7

[Bobby Holley (:bholley)]

(In reply to Glenn Watson [:gw] from comment #6)
> I would be surprised if that change resulted in a memory reduction. It's
> possible, but unlikely. What were the other changes?

See the URL field of this bug. Anyway, not super important.