Bug 1498917 - Make ext-sidebarAction.js consistent with ext-browserAction.js after Bug 1498917. r=mixedpuppy
46 bytes, text/x-phabricator-request
|Details | Review|
In bug 1390464 I changed the signature of sidebarAction's internal getProperty and setProperty functions. Then I applied the same change to browserAction in bug 1419893. The problem was that some browserAction callers still needed the old signature, so I had to do some refactoring in bug 1483684. The outcome was that the internal code for sidebarAction and browserAction differ. sidebarAction should be updated to match browserAction after bug 1483684. This should have no observable effect in practice.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/344d0af4e60c Make ext-sidebarAction.js consistent with ext-browserAction.js after Bug 1498917. r=mixedpuppy
Can you please add some STRs for this bug(and a test webextension if possible) or mark it as "qe-verify-" ?
Just a refactoring, no observable effects.
You need to log in before you can comment on or make changes to this bug.