Closed Bug 1498917 Opened Last year Closed Last year

Make ext-sidebarAction.js consistent with ext-browserAction.js after bug 1483684

Categories

(WebExtensions :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

In bug 1390464 I changed the signature of sidebarAction's internal getProperty and setProperty functions.
Then I applied the same change to browserAction in bug 1419893.
The problem was that some browserAction callers still needed the old signature, so I had to do some refactoring in bug 1483684.
The outcome was that the internal code for sidebarAction and browserAction differ.
sidebarAction should be updated to match browserAction after bug 1483684.
This should have no observable effect in practice.
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/344d0af4e60c
Make ext-sidebarAction.js consistent with ext-browserAction.js after Bug 1498917. r=mixedpuppy
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/344d0af4e60c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Can you please add some STRs for this bug(and a test webextension if possible) or mark it as "qe-verify-" ?
Just a refactoring, no observable effects.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.