1498958 - (Wtautological-unsigned-zero-compare) Enable clang warnings: -Wtautological-unsigned-zero-compare, -Wtautological-unsigned-enum-zero-compare

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Chris Peterson [:cpeterson]]

With the update to clang 7 (in bug 1492663), some new warning options are available. The following options report some warnings in third-party code (ICU) that is not compiled with warnings-as-errors, so we can enable them by default:

-Wtautological-unsigned-zero-compare: result of comparison of unsigned expression is always true/false

https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-unsigned-zero-compare

-Wtautological-unsigned-enum-zero-compare: result of comparison of unsigned enum expression is always true/false

https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-unsigned-enum-zero-compare

intl/icu/source/common/utrie2.cpp:145:18 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/common/utrie2.cpp:251:17 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/common/utrie2.cpp:466:18 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/common/utrie2_builder.cpp:1266:18 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/i18n/numfmt.cpp:1306:15 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/i18n/reldatefmt.cpp:551:27 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression >= 0 is always true
intl/icu/source/i18n/tmunit.cpp:64:23 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/i18n/unum.cpp:782:27 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false
intl/icu/source/i18n/unum.cpp:809:27 [-Wtautological-unsigned-enum-zero-compare] comparison of unsigned enum expression < 0 is always false

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1498958 - Enable clang warnings: -Wtautological-unsigned-zero-compare, -Wtautological-unsigned-enum-zero-compare. r?glandium

-Wtautological-unsigned-zero-compare: result of comparison of unsigned expression is always true/false

https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-unsigned-zero-compare

-Wtautological-unsigned-enum-zero-compare: result of comparison of unsigned enum expression is always true/false

https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-unsigned-enum-zero-compare

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46c013fd9f6a
Enable clang warnings: -Wtautological-unsigned-zero-compare, -Wtautological-unsigned-enum-zero-compare. r=glandium

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/46c013fd9f6a