1499021 - Pressing "raw headers" seemingly crashes the Network panel

Status: NEW

(DevTools :: Netmonitor, defect, P3)

Description

[Anne (:annevk)]

Load these bytes over an HTTP connection (copied from Hex Fiend on macOS):

  48545450 2F312E31 20323030 204F4B0D 436F6E74 656E742D 54797065 3A207465 78742F70 6C61696E 0A0A426F 64792E

(E.g., via a .asis resource on web-platform-tests.)

Then go the network panel, reload, select the resource, select raw headers. The whole network panel goes blank and doesn't reappear.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

Can you please provide a simple test case (e.g. an online page or a HTML page attached to this bug) + detailed instructions what to do to reproduce the problem on my machine?

Thanks!
Honza

Comment 2

[Anne (:annevk)]

Tried to ping you on Slack, but no luck. If comment 0 is not sufficient (i.e., you don't have web-platform-tests somehow) I won't be able to get to this for a while.

Comment 3

[Anne (:annevk)]

Attachment: cr-delimited-http.asis

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Anne: thanks for the file!

@James: I am seeing the following problem when trying to run wpt. Note that I am on Windows 10

Honza


$ mach wpt cr-delimited-http.asis
 0:01.15 INFO Creating config file c:/src/mozilla.org/mozilla-central/obj-i686-pc-mingw32\_tests\web-platform\wptrunner.local.ini
 0:01.16 INFO Creating directory c:\src\mozilla.org\mozilla-central\obj-i686-pc-mingw32\_tests\web-platform\meta
 0:01.16 INFO Creating directory c:\src\mozilla.org\mozilla-central\obj-i686-pc-mingw32\_tests\web-platform\mozilla\meta
 0:09.12 INFO Downloading manifest from https://index.taskcluster.net/v1/task/gecko.v2.mozilla-central.revision.d49587f5ccd37180d1f0d980c9dd076e7afa1bcb.source.manifest-upload/artifacts/public/manifests.tar.gz
 0:12.89 INFO Updating manifest c:\src\mozilla.org\mozilla-central\obj-i686-pc-mingw32\_tests\web-platform\meta\MANIFEST.json
 1:20.10 INFO Updating manifest c:\src\mozilla.org\mozilla-central\obj-i686-pc-mingw32\_tests\web-platform\mozilla\meta\MANIFEST.json
Error running mach:

    ['wpt', 'cr-delimited-http.asis']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: DLL load failed: %1 is not a valid Win32 application.

  File "c:\src\mozilla.org\mozilla-central\testing/web-platform/mach_commands.py", line 353, in run_wpt
    return self.run_web_platform_tests(**params)
  File "c:\src\mozilla.org\mozilla-central\testing/web-platform/mach_commands.py", line 346, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "c:\src\mozilla.org\mozilla-central\testing/web-platform\mach_commands_base.py", line 31, in run
    kwargs = self.setup.kwargs_firefox(kwargs)
  File "c:\src\mozilla.org\mozilla-central\testing/web-platform/mach_commands.py", line 81, in kwargs_firefox
    kwargs = self.kwargs_common(kwargs)
  File "c:\src\mozilla.org\mozilla-central\testing/web-platform/mach_commands.py", line 30, in kwargs_common
    from mozrunner.devices.android_device import verify_android_device, grant_runtime_permissions
  File "c:\src\mozilla.org\mozilla-central\build/mach_bootstrap.py", line 349, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "c:\src\mozilla.org\mozilla-central\testing/mozbase/mozrunner\mozrunner\devices\android_device.py", line 11, in <module>
    import psutil
  File "c:\src\mozilla.org\mozilla-central\build/mach_bootstrap.py", line 349, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "c:\src\mozilla.org\mozilla-central\third_party/python/psutil-cp27-none-win_amd64\psutil\__init__.py", line 146, in <module>
    from . import _pswindows as _psplatform
  File "c:\src\mozilla.org\mozilla-central\build/mach_bootstrap.py", line 349, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "c:\src\mozilla.org\mozilla-central\third_party/python/psutil-cp27-none-win_amd64\psutil\_pswindows.py", line 16, in <module>
    from . import _psutil_windows as cext
  File "c:\src\mozilla.org\mozilla-central\build/mach_bootstrap.py", line 349, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Just a note, use this MDN page to learn about WPT:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests

Honza

Comment 6

[James Graham [:jgraham]]

OK, so the fact that android_device is on the callstack in the absence of --product=fennec seems wrong. And the fact that psutil seems to be failing to load also seems concerning (although I think we shouldn't be doing it at all in this case). So needinfo ted for the latter issue, and I'll investigate the former.

Comment 7

[James Graham [:jgraham]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1499061 should fix this.

Comment 8

[(not currently active) Ted Mielczarek]

The android bits seem to have been added recently in bug 1496627:
https://hg.mozilla.org/mozilla-central/annotate/224715760a63/testing/web-platform/mach_commands.py#l30

Comment 9

[(not currently active) Ted Mielczarek]

honza: are you using an older MozillaBuild with a 32-bit Python? I vendored a psutil wheel in bug 1481612, but it's for Win64. I assumed everyone building on Windows was using a 64-bit Python at this point.

Comment 10

[(not currently active) Ted Mielczarek]

MozillaBuild made the default Python 64-bit in bug 1344643, which shipped in MozillaBuild 3.0.

Comment 11

[James Graham [:jgraham]]

jonco also mentioned seeing this issue on Linux, so I wonder if we need to explictly install psutil into the virtualenv in the fennec case, or something (but this should really be in a different bug now).

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #9)
> honza: are you using an older MozillaBuild with a 32-bit Python? I vendored
> a psutil wheel in bug 1481612, but it's for Win64. I assumed everyone
> building on Windows was using a 64-bit Python at this point.

I am using version 3.2

Honza

Comment 13

[(not currently active) Ted Mielczarek]

Honza: can you run python -c 'import platform; print platform.architecture()' and paste the output here? On my Windows machine it produces:

$ python -c 'import platform; print platform.architecture()'
('64bit', 'WindowsPE')

Comment 14

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorry for late reply!

Honza: can you run python -c 'import platform; print platform.architecture()' and paste the output here? On my Windows machine it produces:

$ python -c 'import platform; print platform.architecture()'
('64bit', 'WindowsPE')