1499028 - Update list of currency codes to include Unidad Previsional (UYW)

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

Unidad Previsional (UYW) was added in <https://www.currency-iso.org/dam/downloads/dl_currency_iso_amendment_169.pdf>.

Comment 1

[André Bargull [:anba]]

Attachment: bug1499028.patch

Comment 2

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8958ed1880df54e4e2d3629dd9a5ca7e4c15d840

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f8dc84aade
Update list of currencies for Intl.NumberFormat. r=Waldo

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/76f8dc84aade

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Waldo, maybe you have an opinion?

Comment 7

[Jeff Walden [:Waldo]]

It's an easy and simple backport.  Might help some people out.  I'd say, why not?  Especially for ESR given its longevity, and the likelihood it will keep existing as new uses of UYW pop up.

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 9017128 [details] [diff] [review]
bug1499028.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Formatting a number as units of Uruguay currency won't be quite right in certain places.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Not risky -- only changes self-hosted code, adds a member to an object literal there, if that triggers problems something more would have to be seriously wrong.

String changes made/needed: N/A

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: People formatting units of a Uruguay currency should get proper formatting.  This isn't the end of the world if it doesn't happen, but if we're updating stable branches for time zone sorts of changes, this seems of comparable importance for those Uruguay users.

User impact if declined: People default-formatting numbers as units of a certain Uruguay currency will get bad formatting.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): See earlier

String or UUID changes made by this patch: N/A

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9017128 [details] [diff] [review]
bug1499028.patch

New currency formatting, seems potentially useful to users and a safe uplift.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7e6e1cdaaad3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/a62ede2dd3bc