Closed Bug 1499028 Opened 1 year ago Closed 1 year ago

Update list of currency codes to include Unidad Previsional (UYW)

Categories

(Core :: JavaScript: Internationalization API, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 64+ fixed
firefox63 --- wontfix
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Attached patch bug1499028.patchSplinter Review
Attachment #9017128 - Flags: review?(jwalden+bmo)
Attachment #9017128 - Flags: review?(jwalden+bmo) → review+
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f8dc84aade
Update list of currencies for Intl.NumberFormat. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76f8dc84aade
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Is this something we should consider backporting to Beta?
Flags: needinfo?(andrebargull)
Waldo, maybe you have an opinion?
Flags: needinfo?(jwalden+bmo)
It's an easy and simple backport.  Might help some people out.  I'd say, why not?  Especially for ESR given its longevity, and the likelihood it will keep existing as new uses of UYW pop up.
Flags: needinfo?(jwalden+bmo)
Comment on attachment 9017128 [details] [diff] [review]
bug1499028.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Formatting a number as units of Uruguay currency won't be quite right in certain places.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Not risky -- only changes self-hosted code, adds a member to an object literal there, if that triggers problems something more would have to be seriously wrong.

String changes made/needed: N/A

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: People formatting units of a Uruguay currency should get proper formatting.  This isn't the end of the world if it doesn't happen, but if we're updating stable branches for time zone sorts of changes, this seems of comparable importance for those Uruguay users.

User impact if declined: People default-formatting numbers as units of a certain Uruguay currency will get bad formatting.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): See earlier

String or UUID changes made by this patch: N/A
Attachment #9017128 - Flags: approval-mozilla-esr60?
Attachment #9017128 - Flags: approval-mozilla-beta?
Comment on attachment 9017128 [details] [diff] [review]
bug1499028.patch

New currency formatting, seems potentially useful to users and a safe uplift.
Attachment #9017128 - Flags: approval-mozilla-esr60?
Attachment #9017128 - Flags: approval-mozilla-esr60+
Attachment #9017128 - Flags: approval-mozilla-beta?
Attachment #9017128 - Flags: approval-mozilla-beta+
Flags: needinfo?(andrebargull)
You need to log in before you can comment on or make changes to this bug.