ensure JSGC_DISABLE_POISONING is enable for raptor and jsshell-bench tests

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jmaher, Assigned: Bebe)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

we have this enabled in the environment variables for talos:
https://searchfox.org/mozilla-central/source/testing/talos/talos/ttest.py#128

this should be the case for raptor and jsshell/bench
:bebe, interested in working on this bug?
Flags: needinfo?(bebe)
Yep On it
Assignee: nobody → bebe
Flags: needinfo?(bebe)
:jmaher I added the changes for raptor 

Still investigating n how to run/use jsshell-bench
If you have any docs on jsshell-bench it's more than appreciated

I will update the commit tomorrow but you can take a look over the current changes
Flags: needinfo?(jmaher)
jsshell-bench runs on linux only and requires the js shell, so the runner is different and it doesn't use mozharness, just mach directly (for CI automation).  Running locally, I am not sure, but try pushes can help confirm any changes.

Here is the benchmark runner:
https://searchfox.org/mozilla-central/source/testing/jsshell/benchmark.py
Flags: needinfo?(jmaher)
Thank you.
Does it already work for AWSY?
Blocks: 1433007
:bebe I made a push to Try [1]. It will run your changes on some js-shell tests we have inside Raptor.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=742158f6eca5c9b8ebdef50ccc9b54af12fb3122
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d2cb65d5099
ensure JSGC_DISABLE_POISONING is enable for raptor and jsshell-bench tests r=jmaher
https://hg.mozilla.org/mozilla-central/rev/2d2cb65d5099
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.