Closed
Bug 1499043
Opened 6 years ago
Closed 6 years ago
ensure JSGC_DISABLE_POISONING is enable for raptor and jsshell-bench tests
Categories
(Testing :: Raptor, enhancement)
Testing
Raptor
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jmaher, Assigned: Bebe)
References
Details
Attachments
(1 file)
we have this enabled in the environment variables for talos: https://searchfox.org/mozilla-central/source/testing/talos/talos/ttest.py#128 this should be the case for raptor and jsshell/bench
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
:jmaher I added the changes for raptor Still investigating n how to run/use jsshell-bench If you have any docs on jsshell-bench it's more than appreciated I will update the commit tomorrow but you can take a look over the current changes
Flags: needinfo?(jmaher)
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3430f5d956d41770933c91434106d14194294b5a
Reporter | ||
Comment 6•6 years ago
|
||
jsshell-bench runs on linux only and requires the js shell, so the runner is different and it doesn't use mozharness, just mach directly (for CI automation). Running locally, I am not sure, but try pushes can help confirm any changes. Here is the benchmark runner: https://searchfox.org/mozilla-central/source/testing/jsshell/benchmark.py
Flags: needinfo?(jmaher)
Comment 9•6 years ago
|
||
:bebe I made a push to Try [1]. It will run your changes on some js-shell tests we have inside Raptor. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=742158f6eca5c9b8ebdef50ccc9b54af12fb3122
Comment 10•6 years ago
|
||
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d2cb65d5099 ensure JSGC_DISABLE_POISONING is enable for raptor and jsshell-bench tests r=jmaher
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d2cb65d5099
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•