1499067 - nativeTab.browser.ownerGlobal.BrowserApp.closeTab not implemented in Geckoview

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

I have seen the following error in the android logcat when running speedometer:

10-14 16:32:44.131  5673  5692 E GeckoConsole: [JavaScript Error: "nativeTab.browser.ownerGlobal.BrowserApp.closeTab is not a function" {file: "chrome://geckoview/content/ext-tabs.js" line: 309}]
10-14 16:32:44.131  5673  5692 E GeckoConsole: remove@chrome://geckoview/content/ext-tabs.js:309:13
10-14 16:32:44.131  5673  5692 E GeckoConsole: call/result</<@resource://gre/modules/ExtensionParent.jsm:948:49
10-14 16:32:44.131  5673  5692 E GeckoConsole: withPendingBrowser@resource://gre/modules/ExtensionParent.jsm:602:26
10-14 16:32:44.131  5673  5692 E GeckoConsole: call/result<@resource://gre/modules/ExtensionParent.jsm:947:16
10-14 16:32:44.131  5673  5692 E GeckoConsole: withTiming@resource://gre/modules/ExtensionParent.jsm:914:14
10-14 16:32:44.131  5673  5692 E GeckoConsole: call@resource://gre/modules/ExtensionParent.jsm:946:20

When the raptor webext calls cleanUp in https://searchfox.org/mozilla-central/source/testing/raptor/webext/raptor/runner.js#367 it calls ext.tabs.remove(testTabID) in https://searchfox.org/mozilla-central/source/mobile/android/components/extensions/ext-tabs.js#302 which makes the call to nativeTab.browser.ownerGlobal.BrowserApp.closeTab(nativeTab);

which is not implemented.

Example: https://treeherder.mozilla.org/logviewer.html#?job_id=205419101&repo=mozilla-central

This is reproducible when running locally via 

./mach raptor-test --test raptor-speedometer --app=geckoview --binary="org.mozilla.geckoview_example"

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

This blocks raptor stuff

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1499067 - Stub implementation of BrowserApp.closeTab for GeckoView. r=snorp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412a0c8ee8c4
Stub implementation of BrowserApp.closeTab for GeckoView. r=snorp

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/412a0c8ee8c4

Comment 5

[Chris Peterson [:cpeterson]]

64=wontfix because we don't need to uplift this Raptor test fix.

Comment 6

[Chris Peterson [:cpeterson]]

status-geckoview64=wontfix