1499083 - The "Dismiss" button from the "NEWSLETTER" snippet is wrongly displayed on a white background, if the browser's "Dark" theme is active

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 64.0a1 Build ID - 20181015100128

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.
- Have the browser's "Dark" theme enabled from "about:addons>Themes"
- Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and navigate to "about:newtab#asrouter" page.
2. Go to the "NEWSLETTER_TEST_1" section and click the "Show" button.
3. Click the "Continue" button from the snippet displayed in the bottom part of the page.
4. Observe the behavior.
 
[Expected result]:
- The color of the snippet's background and of the displayed elements respect the "Dark" theme color.

[Actual result]:
- The "Dismiss" button is displayed on a white background.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4501

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4bad95053fd1b3d3ff3a71adc6a32727a71e311c
Fix Bug 1499083 - Fix 'Dismiss' button colour in Newsletter snippet dark theme (#4501)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/826cd78b94cb

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (64.0a1 Build ID - 20181021220134) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the snippet's background respects the "Dark" theme color.