1499088 - Disable WebRender for the build before 64.0 RC

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1498711 we're turning on WebRender without #ifdef guards so that it can ride to late beta. However we want to turn it off for the build before 64 reaches RC, and this bug is to track that. This bug should block the 64 release so that we don't accidentally ship WebRender on 64 release.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch to land on mozilla-beta for the build prior to RC

This is the patch that will need to land on mozilla-beta. Putting it here now so it's ready to go.

Comment 2

[Maire Reavy [:mreavy]]

Kats -- Can I give this to you?  To make sure this lands before RC.  It's already marked tracking for 64 and on my radar as well.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This should land on Nov 30

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 9017195 [details] [diff] [review]
Patch to land on mozilla-beta for the build prior to RC

This needs to land on mozilla-beta before the Nov 30 build (according to :mreavy). Not sure if there's any more beta builds between now and then, but requesting approval to land on beta. If there are going to be more builds please let me know when the last build prior to the Nov 30 is going to be cut, so I can land after that happens.

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9017195 [details] [diff] [review]
Patch to land on mozilla-beta for the build prior to RC

The last beta (64.0b14) builds tomorrow (Nov 28), and ships Thursday (we moved it a day early to accomodate Romanian holiday on Nov 30).
The next build after that is 64.0 rc1 on Monday, December 3.

Are we ok to land this for 64.0b14?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Yeah, I think so. comment 0 says "the build before RC" which I guess is the build tomorrow. I'll push this to beta now.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-beta/rev/a50d4342bc54d61b32bce30b13202d489c104766

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I filed bug 1510289 to track doing the same thing on the 65 train.

Comment 9

[Bogdan Maris, Desktop Test Engineering (Out till 23th April)]

We should definitely verify that this is turned off in 64.0b14.

Comment 10

[Rares Doghi, Desktop QA]

Hi, I checked this issue in Beta 64.0b13 and the WebRender was Turned ON but in the latest Beta 64.0b14 it was Turned OFF. I will mark this issue accordingly.