Open Bug 1499093 Opened Last year Updated 14 hours ago

The autocomplete suggestion popup is visible while in URL/search entering mode

Categories

(Firefox for Android :: General, defect, P2)

All
Android
defect

Tracking

()

Tracking Status
firefox-esr68 --- affected
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fix-optional
firefox66 --- affected
firefox67 --- affected
firefox68 --- affected

People

(Reporter: stefan.deiac, Assigned: brad.arant, NeedInfo)

Details

Attachments

(2 files)

Attached image ss.png
Environment: 
Devices: Motorola Nexus 6 (Android 7.1.1), OnePlus 5T (Android 8.1.0), LG G4 (Android 6.0) and HTC 10 (Android 8.0.0);
Build: Nightly 64.0a1 (2018-10-14), Beta 63.0b13 and Release 62.0.3

Preconditions:
You need to have some logins saved..

Steps to reproduce:
1. Go on https://m.facebook.com;
2. Tap on the email field to open the autocomplete suggestion;
3. Tap on the url bar and type 'amaz';
4. Switch to the landscape mode;
5. Observe the behavior.

Expected result:
The page it's rendered correctly without any layout problem.

Actual result:
The autocomplete suggestion it's backgrounded behind the search engine bar. 

Note:
- see attached screenshots
Hardware: ARM → All
Summary: The autocomplete suggestion it's backgrounded behind the search engine bar → The autocomplete suggestion popup is visible while in URL/search entering mode
Also reproducible on the actual version of Nightly 65.0a1 (2018-10-24) on Google Pixel (Android 9), Nokia 6 (Android 7.1.1).
Not reproducible on Samsung Galaxy Tab S3 (Android 8.0.0) and Huawei MediaPad M2 (Android 5.1.1).
After further investigation, I found that this issue it's occurring also on portrait mode. The only difference is that you need to start the steps on landscape mode.
Assignee: nobody → andrei.a.lazar

Where do I begin. This has been a difficult bug. The premise that I operated under is that the auto-suggest drop down is relevant after the use touches the input box and as soon as they do another action the box should disappear as it is no longer relevant.

Based upon that I have added a focus listener to the GeckoView component to ensure the popup list is hidden when the user clicks (or touches) away from the input field. I observed that when cancelling Fennec with a swipe or switching display modes from portrait to landscape and back that the list drop down is re-displayed not realizing that it was just closed due to loss of focus. This issue I am still documenting and will submit new bug report.

Based upon that, Fennec tries to re-display the drop down list even though the input field is no longer visible placing on top of the main web page resulting in this bug. I added a check to see if the underlying GeckoView isShown() and prevent the display of the drop down lost if it has a value of false. This ensures that we don't see the drop down if the input field is not being shown in the app. The differential submitted will accomplish this as a 'workaround' until the issues in GeckoView can be addressed.

The issue though is that the GeckoView dispatches what look like extraneous requests which I have documented in bug 1573614. This causes a flashing of the list drop down when the input field is touched due to these seemingly extraneous event requests.

I would also like to point out that adding the isShown() check with the OR condition with the existing check causes the list to stay showing even when you start typing into the input field but the list immediately modifies to 'match' the input string being typed. I think this is the expected behavior but I fear it may cause a regression bug. The source indicated a reference to bug 758820 and bug 632744 and something about confusing some IMEs.

Assignee: andrei.a.lazar → brad.arant

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:brad.arant, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(brad.arant)

Try build with the patch for this ticket applied on top of esr68 - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a07552f285921b05669100fa8c50e395355e9e43

Please test that the described issue does not reproduce anymore.

Flags: qe-verify+

Hello,
I tried to reproduce the issue using the build from comment 7 but I wasn't able.
Devices:

  • OnePlus 5T(Android 9);
  • Nokia 6 (Android 7.1.1).
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.