1499110 - Make CFR/ASR preferences compatible with roll-outs

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Tim Spurway [:tspurway]]

Let's make sure CFR is pref'd on for 64 Beta, but disabled for 64 Release

Comment 1

[Ed Lee :Mardak]

The plan is to assume we'll want CFR on in 64 including Beta and Release. And given that we're on 65 Nightly already, we'll just change the default to on in 65 and uplift to 64 (and no channel checks).

If the results from the study in 63 Release result in turning off, we'll then want to uplift to 64 turning off for Release.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5aac7a7a475a090bc3198c97cd1a8ec48636bf4a
Bug 1499110 - Pref on CFR for all channels

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9fce755a1262

Comment 4

[Ed Lee :Mardak]

Bug 1505929 comment 4 backout link: https://hg.mozilla.org/mozilla-central/rev/4efd19ac076280abf1365b0bb7fd2018ce162b38

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a46fe158e566

Comment 6

[Julien Cristau [:jcristau]]

The study on 63 release (bug 1496181) started November 12.  Running for 3 weeks means end around Dec 3, allowing some time for analysis puts us really really close to the 64 release date.  Is this something we could ship via a pref rollout if time runs out?

Comment 7

[Kate Hudson :k88hudson]

Sure, that sounds good to me.

I will uplift the necessary changes to make this possible

Comment 8

[Kate Hudson :k88hudson]

Attachment: Bug 1499110 - Make CFR/ASR preferences compatible with roll-outs

Comment 9

[Kate Hudson :k88hudson]

Comment on attachment 9026523 [details]
Bug 1499110 - Make CFR/ASR preferences compatible with roll-outs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1499110

User impact if declined: We will not be able to roll-out Contextual Feature recommendations or Snippets to users in 64, which are critical to our goals to improve retention, collect appropriate data to make better decisions in the future. Rolling out reduces risks rather than turning everything on at once. (Note that Bug 1505551 must be landed before this one)

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Set up devtools using the "Prerequisites" instructions here: https://docs.google.com/document/d/1U8QegwAIXcm3pkznL0mvZ2r0tNXSsnbu9rH82c2dNyQ/edit#heading=h.v67ohgjjeblk
    Navigate to about:newtab#asrouter to check the status of all providers.
    Snippets and CFR providers should be ENABLED in a Nightly build, and DISABLED in a release/beta build.

List of other uplifts needed: Bug 1505551

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): Unfortunately it's difficult to add automated testing for default pref values in different channels, however,  this change is required by Normandy's architecture to enable roll-outs; having the ability to roll-back will be less risky than launching at once without that ability.

String changes made/needed:

Comment 10

[Kate Hudson :k88hudson]

Waiting on review to merge this to nightly.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c54f764614f7
Make CFR/ASR preferences compatible with roll-outs r=ursula

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/c54f764614f7

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9026523 [details]
Bug 1499110 - Make CFR/ASR preferences compatible with roll-outs

allow AS CFR rollouts, approved for 64.0b12

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1dca177a37faec8d6645e92888c88e1356ad509e
Backport Bug 1499110 - Make CFR/ASR preferences compatible with roll-outs

https://github.com/mozilla/activity-stream/commit/9cb000b149563238975c7495f9d15b4bbc3ca54a
Merge branch 'central' - Backport Bug 1429940, 1499110

https://github.com/mozilla/activity-stream/commit/0af2f5bfa1d00eeecd90e43a677818bce2481c36
Followup to Backport Bug 1499110 - Fix lint errors

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b57a079eace7

Comment 16

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified the fix on the latest Beta build 64.0b12 (Build ID 20181122182000) and on the latest Nightly 65.0a1 (Build ID 20181122220059) on Windows 10 x64, Mac 10.13.3, and Arch Linux 4.16.