1499136 - Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P1)

Description

[Thomas Wisniewski [:twisniewski]]

Given that we've had three reports against bug 1454325 indicating that the spec isn't quite web-compatible, Anne and I have decided to disable to disable the related about:config flag for now: dom.xhr.standard_content_type_normalization

Comment 1

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a9d5209ae39eddfc8d30c06dad0334319b7839c

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1499136 - Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues; r?hsivonen

Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues

Comment 3

[Thomas Wisniewski [:twisniewski]]

Alright, I don't see anything worrying on the try-run, so I've submitted the pref-flipping patch for review.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Henri, do you think you'll have time to review this soon? I'd like to get this in before beta splits off if possible, to prevent the need for an uplift.

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Thomas Wisniewski [:twisniewski] from comment #4)
> Henri, do you think you'll have time to review this soon? I'd like to get
> this in before beta splits off if possible, to prevent the need for an
> uplift.

I reviewed it earlier already and Phabricator shows it as reviewed to me. If Phabricator shows you something different and landing needs to bypass Phabricator to make progress, please consider this as an r+.

Comment 6

[Thomas Wisniewski [:twisniewski]]

Ah, knowing me I just missed that it had been given an r+ (I'm still not quite used to Phabricator). Thanks!

Requesting check-in.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/affe4a683227
Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues; r=hsivonen

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aafde5f425e
Backed out changeset affe4a683227 for mochitest failures in dom/xhr/tests/test_XHRSendData.htm. CLOSED TREE

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset affe4a683227 (bug 1499136) for mochitest failures in dom/xhr/tests/test_XHRSendData.htm. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=206214083&repo=autoland&lineNumber=4226

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=affe4a683227c556ec3d21bbf9e9024fa4a71a4a

Comment 10

[Thomas Wisniewski [:twisniewski]]

This is actually a race in the test which I didn't realize could happen when I altered it in bug 1454325 (I'm surprised that I had the misfortune of not hitting this in my own try-runs).

I've updated the patch here to avoid that race, by having it do the required setup work in a non-racy sequence during onload, before the createFiles function tries to run the tests.

As I don't see any other weird signs in that try-run, and this is just a minor change to that test (which I verified fixes the glitch for me locally), I'm going to carry over the r+ and re-request check-in.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb500ba0c07
Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues; r=hsivonen

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0bb500ba0c07

Comment 13

[Byron Campen [:bwc]]

https://hg.mozilla.org/projects/larch/rev/7aafde5f425eaebe15aee67f05cb7c6ad02b9324
Backed out changeset affe4a683227 (bug 1499136) for mochitest failures in dom/xhr/tests/test_XHRSendData.htm. CLOSED TREE

https://hg.mozilla.org/projects/larch/rev/0bb500ba0c07c122610452184a162166ff47ce96
Bug 1499136 - Disable dom.xhr.standard_content_type_normalization for now due to webcompat issues; r=hsivonen

Comment 14

[Thomas Wisniewski [:twisniewski]]

Byron, I'm confused. Was this patch backed out, and then pushed again, or was it just backed out?

If it was just backed out, could I see a treeherder link or whatever inspired the backout?

Comment 15

[Byron Campen [:bwc]]

So all I did was merge m-c to larch for a project that the necko/webrtc teams are working on, and one of our standard hg extensions went off the rails and spammed bugzilla pretty badly. It seems to have tried to leave comments on every bug that was merged into larch, before hitting an error and stopping.

Comment 16

[Thomas Wisniewski [:twisniewski]]

OK, thanks.