1499139 - Stop lazy requiring the FlexboxInspector and GridInspector in LayoutView

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

loader.lazyRequireGetter actually has a 3% downside if a module/library is actually required as part of the critical code path (ie, the module is actually required on startup instead of on demand).

We should remove the lazyRequireGetter for the FlexboxInspector and GridInspector since they are both used immediately in the init() of layout.js (part of the critical code path) and layout.js is already lazily required.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1499139.patch [1.0]

I saw a 9ms decrease in loading layout.js.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7339d6aa94f
Stop lazy requiring the FlexboxInspector and GridInspector in LayoutView. r=mtigley

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f7339d6aa94f

Comment 5

[Byron Campen [:bwc]]

https://hg.mozilla.org/projects/larch/rev/f7339d6aa94f5f9442d47aebab625a4fe3ef0f4e
Bug 1499139 - Stop lazy requiring the FlexboxInspector and GridInspector in LayoutView. r=mtigley

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1499139 - Canonicalize pdf mime type testing;

Adds a nsContentUtils method to check for pdf mime types, ignoring
parameters that may be included with the type.

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 9022347 [details]
Bug 1499139 - Canonicalize pdf mime type testing;

Accidental addition of patch for bug 1499169 to wrong bug. Obsoleting.