Closed Bug 1499184 Opened 2 years ago Closed 2 years ago

<select size=1> inline-size is too narrow when it renders a display:none <option>

Categories

(Core :: Layout: Form Controls, defect, P4)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: testcase)

Attachments

(2 files)

Testcase
1.13 KB, text/html
Details
fix+reftest
4.78 KB, patch
jwatt
: review+
Details | Diff | Splinter Review
Attached file Testcase — 
The two <select>s in the testcase renders exactly the same in
Edge, Chrome, and Safari, respectively.

In Firefox, the 2nd <select> in each set appears to have a too narrow content-box inline-size.
Actually, you'll need a fix for bug 1499127 to see the <option>
in the 2nd <select> at all...
Depends on: 1499127
Summary: <select> inline-size is too narrow when it renders a display:none <option> → <select size=1> inline-size is too narrow when it renders a display:none <option>
Attached patch fix+reftest — — Splinter Review 
FYI, this also fixes the bug on Android, but I'm skipping the reftest
there because the -ref renders differently there for some *other* reason.
(Presumably because of some weird rule in
mobile/android/themes/geckoview/content.css as usual.)
Assignee: nobody → mats
Attachment #9019836 - Flags: review?(jwatt)
Attachment #9019836 - Flags: review?(jwatt) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a218f406da67
Add some inline-axis padding after the <select size=1> display frame to avoid the text being flush to the dropdown button when we have a display:none <option>.  r=jwatt
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/a218f406da67
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Does this need a Beta uplift request?
Flags: needinfo?(mats)
Nope.
Flags: needinfo?(mats)
You need to log in before you can comment on or make changes to this bug.