1499208 - TV-bf sometimes fails to run a test due to gpu/non-gpu task mismatch

Status: RESOLVED FIXED

(Testing :: General, enhancement, P2)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1483292 +++

In bug 1483292 we found that some "TV-bf notfound" instances are because backfill started a TVg task where it should have started a TV task: The TVg task finds no matching gpu tests.

Example: https://bugzilla.mozilla.org/show_bug.cgi?id=1483292#c9, dom/canvas/crashtests/896047-1.html on win7/debug, from bug 1474751.

Comment 1

[Geoff Brown [:gbrown]]

In addition to https://bugzilla.mozilla.org/show_bug.cgi?id=1483292#c10, consider 

https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/mozharness/mozilla/testing/per_test_base.py#127-132

That is, in TV and TVg mozharness-level processing, a modified-or-requested test is a gpu test if it is found in a manifest for a test suite with subsuite 'gpu' or 'webgl*'.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: use task name to determine gpu-ness of backfill

TV chunk estimation still uses different rules - let's leave that for another bug.

Here I was able to run TV-bf on dom\canvas\crashtests\896047-1.html:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=ddfeb1dcf1e8961335dc28b1f9439a75a086a2be&selectedJob=205657168

and TVg-bf on a reftest:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=ddfeb1dcf1e8961335dc28b1f9439a75a086a2be&selectedJob=205897832

Comment 3

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 9017647 [details] [diff] [review]
use task name to determine gpu-ness of backfill

Review of attachment 9017647 [details] [diff] [review]:
-----------------------------------------------------------------

cool, thanks for fixing my sloppy work for earlier this year.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad5c00150c8
Use task name to determine gpu-ness of backfilled tasks; r=jmaher

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3ad5c00150c8