1499222 - reference to undefined property "listChild" in extensions.js:1644

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[:aceman]

Just opening the addon manager I get this error in console:
reference to undefined property "listChild" in extensions.js:1644

There seems to be an obvious typo in that code:
  while (aList.listChild)
    aList.removeChild(aList.lastChild);

This was landed in 2010 so something must have changed so that the error is exposed only now:
https://hg.mozilla.org/mozilla-central/rev/61deb05747d6

Comment 1

[:aceman]

Attachment: 1499222.patch - change to r=kmag

This should do it.

Comment 2

[:aceman]

Thanks.
Should I upload a new patch with the reviewer fixed, or will the person checking it in do it?

Comment 3

[Kris Maglione [:kmag]]

(In reply to :aceman from comment #2)
> Thanks.
> Should I upload a new patch with the reviewer fixed, or will the person
> checking it in do it?

A sheriff will do it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdfa6fafe6a9
Fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a230ab0deaba
fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a230ab0deaba

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fdfa6fafe6a9