Closed Bug 1499222 Opened 2 years ago Closed 2 years ago

reference to undefined property "listChild" in extensions.js:1644

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

Just opening the addon manager I get this error in console:
reference to undefined property "listChild" in extensions.js:1644

There seems to be an obvious typo in that code:
  while (aList.listChild)
    aList.removeChild(aList.lastChild);

This was landed in 2010 so something must have changed so that the error is exposed only now:
https://hg.mozilla.org/mozilla-central/rev/61deb05747d6
This should do it.
Attachment #9017342 - Flags: review?(dtownsend)
Attachment #9017342 - Flags: review?(kmaglione+bmo)
Attachment #9017342 - Flags: review?(kmaglione+bmo)
Attachment #9017342 - Flags: review?(dtownsend)
Attachment #9017342 - Flags: review+
Thanks.
Should I upload a new patch with the reviewer fixed, or will the person checking it in do it?
Keywords: checkin-needed
(In reply to :aceman from comment #2)
> Thanks.
> Should I upload a new patch with the reviewer fixed, or will the person
> checking it in do it?

A sheriff will do it.
Attachment #9017342 - Attachment description: 1499222.patch → 1499222.patch - change to r=kmag
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdfa6fafe6a9
Fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a230ab0deaba
fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
https://hg.mozilla.org/mozilla-central/rev/a230ab0deaba
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.