1499281 - Remove preference "layout.css.column-span.enabled" after it reaches the release channel

Status: RESOLVED FIXED

(Core :: Layout: Columns, enhancement, P4)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This won't happen soon, but no harm to file a bug for that.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

It's time to remove the pref.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in nsColumnSetFrame.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in nsBlockFrame.

Depends on D58396

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in nsCSSFrameConstructor.

For BeginBuildingColumns, returning nsBlockFrame, i.e. the original
NS_NewColumnSetWrapperFrame's return type, should be sufficient since no
other caller in frame constructor needs to call ColumnSetWrapper's
methods.

Depends on D58397

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in column.mako.rs.

Depends on D58398

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Delete column-span pref in wpt meta files.

Depends on D58399

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in reftest.list/crashtest.list, and remove duplicate reftest runs.

Depends on D58400

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in mochitests and property databases.

Move the content of bug1503420.html to
test_frame_reconstruction_for_column_span.html because we don't need to
flip the pref and load the test in an iframe.

The modification to devtools's properties-db.js is generated via
./mach devtools-css-db.

Depends on D58401

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1499281 - Remove column-span pref in StaticPrefList.yaml (finale).

Depends on D58402

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62a41cc1264e
Remove column-span pref in nsColumnSetFrame. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/d1e2cdfd4b57
Remove column-span pref in nsBlockFrame. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/a761a31f55f7
Remove column-span pref in nsCSSFrameConstructor. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/bd4c3d514387
Remove column-span pref in column.mako.rs. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/a9f7a8549f23
Delete column-span pref in wpt meta files. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/f33481e1f091
Remove column-span pref in reftest.list/crashtest.list, and remove duplicate reftest runs. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/b463feb2d14f
Remove column-span pref in mochitests and property databases. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/6acdb1c2177c
Remove column-span pref in StaticPrefList.yaml (finale). r=dbaron

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/62a41cc1264e
https://hg.mozilla.org/mozilla-central/rev/d1e2cdfd4b57
https://hg.mozilla.org/mozilla-central/rev/a761a31f55f7
https://hg.mozilla.org/mozilla-central/rev/bd4c3d514387
https://hg.mozilla.org/mozilla-central/rev/a9f7a8549f23
https://hg.mozilla.org/mozilla-central/rev/f33481e1f091
https://hg.mozilla.org/mozilla-central/rev/b463feb2d14f
https://hg.mozilla.org/mozilla-central/rev/6acdb1c2177c

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

WPT import in https://github.com/web-platform-tests/wpt/pull/21926 (delayed since I don't monitor reftest.list files).