1499343 - Unable to delete a tag: Empty array passed for required input property: urls

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[jiri.pospisil]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

I'm not sure how I've gotten into this state but I have a tag which is not assigned to any bookmarks and I cannot delete it. The bookmarks have been imported from Chrome a long time ago and used from a different versions of Firefox (I'm using the latest Nightly right now 64.0a1 (2018-10-15) (64-bit)).

1. Open Library
2. Right click a tag and select delete


Actual results:

The tag is not deleted, it stays there. When I open the Browser Console, I can see there's the following error:

11:18:05.677 Empty array passed for required input property:
                           urls PlacesTransactions.jsm:826
	validateInput resource://gre/modules/PlacesTransactions.jsm:826:17
	DefineTransaction.validatePropertyValue resource://gre/modules/PlacesTransactions.jsm:847:36
	DefineTransaction.verifyInput resource://gre/modules/PlacesTransactions.jsm:891:24
	ctor resource://gre/modules/PlacesTransactions.jsm:693:15
	ctor resource://gre/modules/PlacesTransactions.jsm:689:14
	_removeRange chrome://browser/content/places/controller.js:815:27
	next self-hosted:1210:9

https://i.imgur.com/mwK7Qz3.png


Expected results:

I guess it should not be possible to get into this state in the first place (I assume tags without assigned bookmarks are deleted automatically), but since I'm there it should just delete the tag.

Comment 1

[jiri.pospisil]

To be clear, it's just this one specific tag. I've tried to reproduce it but I couldn't - tags are properly deleted.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Hi jiri.pospisil,

Do you remember by any chance for which site was that tag used for or any other details that might be the cause of the issue?
I also tried to delete tags and its working fine on Nightly, as u also mentioned. 
It might also be important if that tag is from importing Chrome bookmarks or it is a messed up Firefox tag. 
Tried to reproduce on Windows 10 and Mac OS 10.13.

Thanks!

Comment 3

[jiri.pospisil]

Hello, I was finally able to reproduce it with a clean profile.

1. Open Library (cmd+shift+b).
2. Navigate to example.com and tag it as "example".
3. Open the Bookmark sidebar, search for "example" and delete the only result there.
4. Look back to Library, the tag should not have any site associated with it and can't be deleted.

https://streamable.com/sqoa3

Are you able to reproduce it?

Comment 4

[Timea Cernea [:tbabos][inactive]]

I cannot reproduce the issue...tried it using your steps and reversed, no matter how I do it, the tag will always get deleted. Tried it on Mac OS 10.13 using a new clean profile on latest Nightly and the one from 10/18/2018.

As I observed on the recording, it doesn't seem that there are any add-ons installed. If you know there are, please try to reproduce using Safe Mode.

I will assign a component to this issue as it looks pretty obvious on the recording how you reproduce it. Can you also please try to use mozregression to find out if it is a regression?

Link for mozregression: https://mozilla.github.io/mozregression/

Thanks jiri.pospisil!

Comment 5

[Mark Banner (:standard8) (afk until 21st July)]

I can reproduce the issue as shown in the screencast. However, note that the tag goes away if you close the library window and re-open it.

This seems slightly different to the issue in comment 0 where it appears the tag just cannot be deleted even after a restart of Firefox (please correct me if I'm wrong).

If in the worst case, there is an empty tag, it should be removed by our background maintenance process that will run approximately once a day when Firefox is idle.

Please can you try forcing this manually, and see if that helps. To do this:

* Go to Help -> Troubleshooting Information
* Scroll down the page to find the "Places Database" section (it is near the bottom).
* Click the "Verify Integrity" button, this may take a few seconds to run.

Please save a copy of the output, then restart Firefox and see if that has fixed the empty tag issue. If it hasn't please can you paste the output here, or attach it as a file.

Comment 6

[jiri.pospisil]

> As I observed on the recording, it doesn't seem that there are any add-ons installed. If you know there are, please try to reproduce using Safe Mode.

I'm always testing with a clean profile without any changes.

> I can reproduce the issue as shown in the screencast. However, note that the tag goes away if you close the library window and re-open it.

You're right.

> This seems slightly different to the issue in comment 0 where it appears the tag just cannot be deleted even after a restart of Firefox (please correct me if I'm wrong).

Yes, this one is persistent. Verifying integrity and restarting did not make a difference unfortunately:

  > Task: checkIntegrity
  + The places.sqlite database is sane
  + The favicons.sqlite database is sane
  > Task: invalidateCaches
  + The caches have been invalidated
  > Task: checkCoherence
  + The database is coherent
  > Task: expire
  + Database cleaned up
  > Task: originFrecencyStats
  + Recalculated origin frecency stats
  > Task: vacuum
  + Initial database size is 10240KiB
  + The database has been vacuumed
  + Final database size is 10240KiB
  > Task: stats
  + Places.sqlite size is 10240KiB
  + Favicons.sqlite size is 8640KiB
  + pragma_user_version is 52
  + pragma_page_size is 32768
  + pragma_cache_size is -2048
  + pragma_journal_mode is wal
  + pragma_synchronous is 1
  + History can store a maximum of 122689 unique pages
  + Table moz_places has 13146 records
  + Table moz_historyvisits has 26147 records
  + Table moz_inputhistory has 244 records
  + Table moz_hosts has 0 records
  + Table moz_bookmarks has 732 records
  + Table moz_keywords has 2 records
  + Table sqlite_sequence has 1 records
  + Table moz_anno_attributes has 6 records
  + Table moz_annos has 223 records
  + Table moz_items_annos has 7 records
  + Table sqlite_stat1 has 20 records
  + Table moz_bookmarks_deleted has 0 records
  + Table moz_meta has 9 records
  + Table moz_origins has 1686 records
  + Index sqlite_autoindex_moz_inputhistory_1
  + Index sqlite_autoindex_moz_hosts_1
  + Index sqlite_autoindex_moz_keywords_1
  + Index sqlite_autoindex_moz_anno_attributes_1
  + Index sqlite_autoindex_moz_bookmarks_deleted_1
  + Index sqlite_autoindex_moz_origins_1
  + Index moz_places_url_hashindex
  + Index moz_places_hostindex
  + Index moz_places_visitcount
  + Index moz_places_frecencyindex
  + Index moz_places_lastvisitdateindex
  + Index moz_historyvisits_placedateindex
  + Index moz_historyvisits_fromindex
  + Index moz_historyvisits_dateindex
  + Index moz_bookmarks_itemindex
  + Index moz_bookmarks_parentindex
  + Index moz_bookmarks_itemlastmodifiedindex
  + Index moz_places_guid_uniqueindex
  + Index moz_bookmarks_guid_uniqueindex
  + Index moz_keywords_placepostdata_uniqueindex
  + Index moz_annos_placeattributeindex
  + Index moz_items_annos_itemattributeindex
  + Index moz_bookmarks_dateaddedindex
  + Index moz_places_originidindex
  > Task: _refreshUI

I did notice one other thing however: Even though the tag is not associated with the website anymore, I can still type the tag into Address bar and it will find the page! Once I land there, the browser does not show an existing bookmark (blue star in Address bar) but I'm not sure whether we should trust that (To visit the bookmarked page you need to be authenticated and so the page immediately redirects 302 to a login page. I don't have access there anymore so I just prevented the redirect with network.http.redirection-limit = 0) to stay on the bookmarked page). 

https://i.imgur.com/DvtbELm.png
https://i.imgur.com/zMEpcOG.png

Comment 7

[CKOTTMozillaBugzilla]

I am having the same problem, for the past week at least. I have multiple Tags that are no longer assigned to any bookmarks, but they remain in my list of tags.

In addition: Firefox Developer Edition is my daily driver, but I just noticed that my copy of Firefox (release version), which recently updated to version 64.0 (64-bit), is now showing *even older* Tags in the Library, which I had deleted a long time ago, and which *do not* appear in my copy of Firefox Developer Edition 65.0b6 (64-bit).

I'm syncing bookmarks and history between the two versions, and I have not noticed any problems related to syncing.

I've rebooted many times since I first noticed this problem.

OS: Windows 10 Home 64-bit version 1803 build 17134.472

Details for each problematic Tag:
-
- I can add the Tag to a bookmark, and I can remove it from a bookmark.
-
- Tag appears in Library in Tags list in left-hand pane.
-
- If no bookmarks are assigned this Tag:
--- Click on a Tag in Library: No bookmarks are displayed in the right-hand pane.
--- Click on a Tag in Library, then try to change Tag name in right-hand pane: Tag name does not change.
--- Right-click on a Tag in Library, then click on Delete: Tag remains.
-
- If some bookmarks are assigned this Tag:
--- Click on a Tag in Library: Tagged bookmarks are correctly displayed in the right-hand pane.
--- Click on a Tag in Library, then try to change Tag name in right-hand pane: Tag name does not change.
--- Right-click on a Tag in Library, then click on Delete: Previously-tagged bookmarks disappear from right-hand pane, but Tag remains in Library.