Closed Bug 1499359 Opened 11 months ago Closed 11 months ago

Unused import warning: HashMap in servo/components/style/build_gecko.rs

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: bbouvier)

References

Details

Attachments

(2 files)

Since bug 1495669 the following warning happens during the build:

 4:46.66 warning: unused import: `HashMap`
 4:46.66   --> servo/components/style/build_gecko.rs:20:28
 4:46.66    |
 4:46.66 20 |     use std::collections::{HashMap, HashSet};
 4:46.66    |                            ^^^^^^^
 4:46.66    |
 4:46.66    = note: #[warn(unused_imports)] on by default
Blocks: 1495669
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #9017504 - Flags: review?(emilio)
Attached patch 2.rustfmt.patchSplinter Review
What do you think of applying rustfmt (stable) to the build_gecko.rs file?
Attachment #9017505 - Flags: review?(emilio)
Attachment #9017504 - Flags: review?(emilio) → review+
Comment on attachment 9017505 [details] [diff] [review]
2.rustfmt.patch

Review of attachment 9017505 [details] [diff] [review]:
-----------------------------------------------------------------

::: servo/components/style/build_gecko.rs
@@ +14,5 @@
>  
>  #[cfg(feature = "bindgen")]
>  mod bindings {
> +    use super::super::PYTHON;
> +    use super::common::*;

Can you revert these changes? I would need to undo them to sync them to the Servo repo, because servo does it's own `use` statement order checking.

@@ +239,5 @@
>                  panic!(
>                      "Failed to generate bindings, flags: {:?}",
>                      command_line_opts
>                  );
> +            }

Similarly, https://github.com/servo/servo/blob/master/rustfmt.toml#L1 will mean next person that runs rustfmt on servo will revert this.

@@ +588,5 @@
>  }
>  
>  #[cfg(not(feature = "bindgen"))]
>  mod bindings {
> +    use super::common::*;

ditto.
Attachment #9017505 - Flags: review?(emilio) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45de3b6b3996
; Remove unused HashMap import and remove namespacing around Table; r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/000359cfa701
Apply rustfmt on build_gecko.rs; r=emilio
https://hg.mozilla.org/mozilla-central/rev/45de3b6b3996
https://hg.mozilla.org/mozilla-central/rev/000359cfa701
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.