1499359 - Unused import warning: HashMap in servo/components/style/build_gecko.rs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Alex Gaynor [:Alex_Gaynor]]

Since bug 1495669 the following warning happens during the build:

 4:46.66 warning: unused import: `HashMap`
 4:46.66   --> servo/components/style/build_gecko.rs:20:28
 4:46.66    |
 4:46.66 20 |     use std::collections::{HashMap, HashSet};
 4:46.66    |                            ^^^^^^^
 4:46.66    |
 4:46.66    = note: #[warn(unused_imports)] on by default

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.remove-hashmap.patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.rustfmt.patch

What do you think of applying rustfmt (stable) to the build_gecko.rs file?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9017505 [details] [diff] [review]
2.rustfmt.patch

Review of attachment 9017505 [details] [diff] [review]:
-----------------------------------------------------------------

::: servo/components/style/build_gecko.rs
@@ +14,5 @@
>  
>  #[cfg(feature = "bindgen")]
>  mod bindings {
> +    use super::super::PYTHON;
> +    use super::common::*;

Can you revert these changes? I would need to undo them to sync them to the Servo repo, because servo does it's own `use` statement order checking.

@@ +239,5 @@
>                  panic!(
>                      "Failed to generate bindings, flags: {:?}",
>                      command_line_opts
>                  );
> +            }

Similarly, https://github.com/servo/servo/blob/master/rustfmt.toml#L1 will mean next person that runs rustfmt on servo will revert this.

@@ +588,5 @@
>  }
>  
>  #[cfg(not(feature = "bindgen"))]
>  mod bindings {
> +    use super::common::*;

ditto.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45de3b6b3996
; Remove unused HashMap import and remove namespacing around Table; r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/000359cfa701
Apply rustfmt on build_gecko.rs; r=emilio

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/45de3b6b3996
https://hg.mozilla.org/mozilla-central/rev/000359cfa701