Closed Bug 1499369 Opened Last year Closed Last year
_dbg _navigation when Gecko 64 merges to Beta on 2018-10-15
Bug 1499369 - Remove unreferenced event variable in browser_dbg_navigation.js (beta 64 permafail);r=pbro
46 bytes, text/x-phabricator-request
|Details | Review|
central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=dt&selectedJob=205785228 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205785228&repo=try&lineNumber=2119 this looks like a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1485660, https://hg.mozilla.org/mozilla-central/rev/8cf41a5970be Alexandre could you please take a look at this?
It is not clear how to reproduce such failure? And so it is hard to know if I'll correctly fix the error. Is there a particular merge to do between m-c branches, or it is more related to the changes that are bundled in this try run?
Flags: needinfo?(poirot.alex) → needinfo?(csabou)
This is mozilla-central with those two changeset applied: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=retry%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=devtools&selectedJob=205796355 Last good: https://hg.mozilla.org/mozilla-central/rev/4a230b07f0cbf48e87dcb4265ea2d00893bb1b62 First bad: https://hg.mozilla.org/mozilla-central/rev/9079bbe837184ed183b133a374753865b6768bc4
This bug also permafails on beta and needs to be fixed.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
This one seems to fail because of https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_dbg_navigation.js#50 which we forgot to remove in Bug 1485660 The reason it fails on beta only is that we call JSON.stringify(event). `event` is undefined in both beta and central, but on beta event is not referenced at all and this creates a ReferenceError which stops the test. I suppose the global must be slightly different between central and beta.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8c5a1943d169 Remove unreferenced event variable in browser_dbg_navigation.js (beta 64 permafail);r=pbro
Thank you for fixing this so quickly: https://hg.mozilla.org/releases/mozilla-beta/rev/77c7e6536a32bc849151fe864b269de719f831d9 Verified fixed on beta: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=success%2Cusercancel%2Crunnable%2Ctestfailed%2Cbusted%2Cexception%2Cretry&group_state=expanded&searchStr=devtools&revision=affeef3f9bfa52619ab64ebe4e9253a4e4486bcf
You need to log in before you can comment on or make changes to this bug.