1499369 - Perma browser_dbg_navigation when Gecko 64 merges to Beta on 2018-10-15

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Cosmin Sabou [:CosminS]]

central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=dt&selectedJob=205785228

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205785228&repo=try&lineNumber=2119

this looks like a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1485660, https://hg.mozilla.org/mozilla-central/rev/8cf41a5970be

Alexandre could you please take a look at this?

Comment 1

[Alexandre Poirot [:ochameau]]

It is not clear how to reproduce such failure?
And so it is hard to know if I'll correctly fix the error.

Is there a particular merge to do between m-c branches, or it is more related to the changes that are bundled in this try run?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is mozilla-central with those two changeset applied: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=retry%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=devtools&selectedJob=205796355

Last good: https://hg.mozilla.org/mozilla-central/rev/4a230b07f0cbf48e87dcb4265ea2d00893bb1b62 
First bad: https://hg.mozilla.org/mozilla-central/rev/9079bbe837184ed183b133a374753865b6768bc4

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This bug also permafails on beta and needs to be fixed.

Comment 4

[Intermittent Failures Robot]

31 failures in 123 pushes (0.252 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 31

Platform breakdown:
* macosx64-devedition: 2
* linux32-nightly: 2
* linux64-devedition: 2
* linux64-nightly: 2
* macosx64-nightly: 2
* linux32-devedition: 2
* osx-10-10: 2
* windows7-32-nightly: 1
* windows10-64-devedition: 2
* windows10-64: 3
* linux32: 2
* windows7-32-devedition: 2
* windows7-32: 1
* windows10-64-nightly: 2
* linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1499369&startday=2018-10-20&endday=2018-10-20&tree=all

Comment 5

[Intermittent Failures Robot]

31 failures in 2759 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 31

Platform breakdown:
* osx-10-10: 2
* linux32-nightly: 2
* linux64: 4
* macosx64-nightly: 2
* windows7-32: 1
* linux64-nightly: 2
* windows10-64-nightly: 2
* windows10-64: 3
* windows7-32-devedition: 2
* windows7-32-nightly: 1
* linux64-devedition: 2
* linux32-devedition: 2
* linux32: 2
* macosx64-devedition: 2
* windows10-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1499369&startday=2018-10-15&endday=2018-10-21&tree=all

Comment 6

[Julian Descottes [:jdescottes]]

This one seems to fail because of https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_dbg_navigation.js#50 which we forgot to remove in Bug 1485660

The reason it fails on beta only is that we call JSON.stringify(event). `event` is undefined in both beta and central, but on beta event is not referenced at all and this creates a ReferenceError which stops the test. I suppose the global must be slightly different between central and beta.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1499369 - Remove unreferenced event variable in browser_dbg_navigation.js (beta 64 permafail);r=pbro

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c5a1943d169
Remove unreferenced event variable in browser_dbg_navigation.js (beta 64 permafail);r=pbro

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8c5a1943d169

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you for fixing this so quickly:

https://hg.mozilla.org/releases/mozilla-beta/rev/77c7e6536a32bc849151fe864b269de719f831d9

Verified fixed on beta:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=success%2Cusercancel%2Crunnable%2Ctestfailed%2Cbusted%2Cexception%2Cretry&group_state=expanded&searchStr=devtools&revision=affeef3f9bfa52619ab64ebe4e9253a4e4486bcf