Closed Bug 1499421 Opened 2 years ago Closed 2 years ago

Remove `tree-base` binding

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bgrins, Assigned: vporof)

References

Details

Attachments

(1 file)

https://bgrins.github.io/xbl-analysis/tree/#tree-base

After <resources> has been removed, this binding is now only used to share a single one-liner method (_isAccelPressed). We can flatten inheritance by:

1) copy the line `aEvent.getModifierState("Accel")` to child bindings (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/content/widgets/tree.xml#22)
2) remove the tree-base binding
3) make anything that currently `extends="chrome://global/content/bindings/tree.xml#tree-base"` to `extends="chrome://global/content/bindings/general.xml#basecontrol"`
Priority: -- → P5
Attachment #9019944 - Flags: review?(bgrinstead)
Depends on: 1501929
Try looks good.
Blocks: 1499423
Attachment #9019944 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9e5694d74ffb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.