Remove `tree-base` binding

RESOLVED FIXED in Firefox 65

Status

()

task
P5
normal
RESOLVED FIXED
8 months ago
19 days ago

People

(Reporter: bgrins, Assigned: vporof)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

8 months ago
https://bgrins.github.io/xbl-analysis/tree/#tree-base

After <resources> has been removed, this binding is now only used to share a single one-liner method (_isAccelPressed). We can flatten inheritance by:

1) copy the line `aEvent.getModifierState("Accel")` to child bindings (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/content/widgets/tree.xml#22)
2) remove the tree-base binding
3) make anything that currently `extends="chrome://global/content/bindings/tree.xml#tree-base"` to `extends="chrome://global/content/bindings/general.xml#basecontrol"`

Updated

8 months ago
Priority: -- → P5
Assignee

Comment 1

8 months ago
Attachment #9019944 - Flags: review?(bgrinstead)
Depends on: 1501929
Assignee

Comment 3

8 months ago
Try looks good.
Assignee

Updated

8 months ago
Blocks: 1499423
Reporter

Updated

8 months ago
Attachment #9019944 - Flags: review?(bgrinstead) → review+
Assignee

Updated

8 months ago
Keywords: checkin-needed

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9e5694d74ffb
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Updated

19 days ago
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.