https://bgrins.github.io/xbl-analysis/tree/#tree-base After <resources> has been removed, this binding is now only used to share a single one-liner method (_isAccelPressed). We can flatten inheritance by: 1) copy the line `aEvent.getModifierState("Accel")` to child bindings (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/content/widgets/tree.xml#22) 2) remove the tree-base binding 3) make anything that currently `extends="chrome://global/content/bindings/tree.xml#tree-base"` to `extends="chrome://global/content/bindings/general.xml#basecontrol"`
Created attachment 9019944 [details] [diff] [review] remove-tree-base-2018-10-25-0901.diff
Attachment #9019944 - Flags: review?(bgrinstead)
Try looks good.
Attachment #9019944 - Flags: review?(bgrinstead) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e5694d74ffb Remove `tree-base` binding, r=bgrins
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.