Remove `tree-base` binding

RESOLVED FIXED in Firefox 65

Status

()

P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: bgrins, Assigned: vporof)

Tracking

(Blocks: 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
https://bgrins.github.io/xbl-analysis/tree/#tree-base

After <resources> has been removed, this binding is now only used to share a single one-liner method (_isAccelPressed). We can flatten inheritance by:

1) copy the line `aEvent.getModifierState("Accel")` to child bindings (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/content/widgets/tree.xml#22)
2) remove the tree-base binding
3) make anything that currently `extends="chrome://global/content/bindings/tree.xml#tree-base"` to `extends="chrome://global/content/bindings/general.xml#basecontrol"`

Updated

3 months ago
Priority: -- → P5
(Assignee)

Comment 1

3 months ago
Created attachment 9019944 [details] [diff] [review]
remove-tree-base-2018-10-25-0901.diff
Attachment #9019944 - Flags: review?(bgrinstead)
Depends on: 1501929
(Assignee)

Comment 3

3 months ago
Try looks good.
(Assignee)

Updated

3 months ago
Blocks: 1499423
(Reporter)

Updated

3 months ago
Attachment #9019944 - Flags: review?(bgrinstead) → review+
(Assignee)

Updated

3 months ago
Keywords: checkin-needed

Comment 4

3 months ago
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e5694d74ffb
Remove `tree-base` binding, r=bgrins
Keywords: checkin-needed

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9e5694d74ffb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.