Closed
Bug 1499421
Opened 6 years ago
Closed 6 years ago
Remove `tree-base` binding
Categories
(Toolkit :: UI Widgets, task, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: bgrins, Assigned: vporof)
References
Details
Attachments
(1 file)
|
7.31 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
https://bgrins.github.io/xbl-analysis/tree/#tree-base
After <resources> has been removed, this binding is now only used to share a single one-liner method (_isAccelPressed). We can flatten inheritance by:
1) copy the line `aEvent.getModifierState("Accel")` to child bindings (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/content/widgets/tree.xml#22)
2) remove the tree-base binding
3) make anything that currently `extends="chrome://global/content/bindings/tree.xml#tree-base"` to `extends="chrome://global/content/bindings/general.xml#basecontrol"`
|
||
Updated•6 years ago
|
Priority: -- → P5
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9019944 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try looks good.
|
Reporter | |
Updated•6 years ago
|
Attachment #9019944 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e5694d74ffb
Remove `tree-base` binding, r=bgrins
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•