Closed
Bug 1499470
Opened 6 years ago
Closed 6 years ago
Add pref to disable TAAR for Discopane implementation
Categories
(WebExtensions :: Frontend, enhancement, P1)
WebExtensions
Frontend
Tracking
(firefox65 verified)
VERIFIED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | verified |
People
(Reporter: shell, Assigned: mstriemer)
References
Details
(Whiteboard: [ux-decision-needed])
Attachments
(2 files)
Add a preference to disable using TAAR in Discopane. Emanuela is providing the UX.
Trello card: https://trello.com/c/KdUXq179
PRD: https://docs.google.com/document/d/1m_zmiVh1Oq8sz4NPjEQJz5k3MJZSVdpfr6Ar2IvyQpI/edit
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(emanuela)
Updated•6 years ago
|
Whiteboard: [ux-decision-needed]
For reference here is the latest design for how prefs will handle Disco-TAAR opt-out/in:
https://mozilla.invisionapp.com/share/EXO4XHKMD6Z#/screens/325542844
From my PM perspective, this pref UX is good to go, but Emanuela should confirm. (The new element is the checkbox and copy for "Allow Firefox to make personalized extension recommendations" ... The "Learn more" link will go to a SUMO page that is not live yet, though being drafted.)
Assignee | ||
Comment 2•6 years ago
|
||
If we want to open about:preferences from AMO content I wrote a patch to add support for it on mozAddonManager [1]. Not sure if that's what we want to do but if we go that route this might be a good start.
[1] https://hg.mozilla.org/try/rev/8e2abfed97657861a0eebc65ac926477481dae50
Comment 3•6 years ago
|
||
(In reply to sdevaney from comment #1)
> For reference here is the latest design for how prefs will handle Disco-TAAR
> opt-out/in:
>
> https://mozilla.invisionapp.com/share/EXO4XHKMD6Z#/screens/325542844
>
> From my PM perspective, this pref UX is good to go, but Emanuela should
> confirm. (The new element is the checkbox and copy for "Allow Firefox to
> make personalized extension recommendations" ... The "Learn more" link will
> go to a SUMO page that is not live yet, though being drafted.)
yes, I can confirm.
String: Allow Firefox to make personalized extension recommendations
For reference, I'm also attaching the screen.
Flags: needinfo?(emanuela)
Comment 4•6 years ago
|
||
Note: there is a possibility I will add the actual pref in bug 1489531.
Comment 5•6 years ago
|
||
The pref, browser.discovery.enabled, landed with bug 1489531. It is false until this bug adds the UI, so the patch here should change the pref to true.
(In reply to Mark Striemer [:mstriemer] from comment #6)
> Is the SUMO page ready now?
The copy is ready, however the SUMO page itself has not been produced/published. Can you proceed without a specific link, or is that a blocker?
Flags: needinfo?(sdevaney)
Assignee | ||
Comment 8•6 years ago
|
||
It would be good to have the SUMO page up, at least as a placeholder. The page normally has a short name that we can use in product, like https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/extension-recommendations. If you can set that up that'd be cool, in the past I've asked jsavage if you don't have access.
Flags: needinfo?(sdevaney)
Updated•6 years ago
|
Assignee: nobody → mstriemer
Priority: -- → P1
(In reply to Mark Striemer [:mstriemer] from comment #8)
> It would be good to have the SUMO page up, at least as a placeholder. The
> page normally has a short name that we can use in product, like
> https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/extension-
> recommendations. If you can set that up that'd be cool, in the past I've
> asked jsavage if you don't have access.
Here you go:
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/personalized-addons
Assignee: mstriemer → nobody
Flags: needinfo?(sdevaney)
Priority: P1 → --
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mstriemer
Priority: -- → P1
Assignee | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c9bc41949ee
Provide option to opt-out of add-on recommendations r=mixedpuppy,flod,Gijs
Comment 12•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 13•6 years ago
|
||
Verified using Nightly (65.0a1) on Windows 10 x64 and macOS 10.13.6, the pref is present and has been turned to true on the latest builds of Nightly (20181206092619 / 20181205213623).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•