1499545 - WorkerPrivate double-initializes mMainThreadEventTarget

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Description

[Jim Blandy :jimb]

This is a very minor cleanup, but:

WorkerPrivate::mMainThreadEventTarget is initialized to GetMainThreadEventTarget in the member initializer list:

  , mMainThreadEventTarget(GetMainThreadEventTarget())

but then is definitely initialized by every path through the function body. It seems like it would be better to initialize it to nullptr, to ensure a crash if the body fails to attend to it. (This means it could be omitted from the member initialized list altogether, since nsCOMPtr's default constructor initializes the pointer to nullptr.)

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1499545: Don't double-initialize WorkerPrivate::mMainThreadEventTarget. r?baku

Comment 2

[Yaron Tausky [:ytausky]]

Sorry to butt in, but wouldn't it be better to write an initialization function for that member and call it in the initialization list? That way we get static correctness guarantees instead of random crashes. (As a plus, it disentangles the various initialization steps from each other.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbff80c1200f
Don't double-initialize WorkerPrivate::mMainThreadEventTarget. r=baku

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bbff80c1200f