1499615 - side_effect_free: Calling ++this->mSetSinkRequestsCount is only useful for its return value, which is ignored.

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Sylvestre Ledru [:Sylvestre]]

Introduced in bug 934425, coverity says that 
https://searchfox.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#3677
is useless.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1499615 - Silence unused returned value warning and initialize the counter. r?pehrsons

Comment 2

[Alex Chronopoulos [:achronop]]

After doing all the setup and generating the report, I found out that this is the coverage tool something else from coverity tool. Coverity is a static analysis tool. There's no way to test a coverity fix right now. I have to land it and wait for the next coverity build to confirm.

Andreas, given that, are you ok to land this patch as is?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

yeah, it will work!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf707f5b0477
Silence unused returned value warning and initialize the counter. r=pehrsons

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cf707f5b0477

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I confirmed that the issue is marked as fixed by coverity. Thanks!

Comment 7

[Alex Chronopoulos [:achronop]]

Thanks for looking at it Sylvestre!