Closed Bug 1499615 Opened 3 years ago Closed 3 years ago
_effect _free: Calling ++this->m Set Sink Requests Count is only useful for its return value, which is ignored .
46 bytes, text/x-phabricator-request
|Details | Review|
Introduced in bug 934425, coverity says that https://searchfox.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#3677 is useless.
After doing all the setup and generating the report, I found out that this is the coverage tool something else from coverity tool. Coverity is a static analysis tool. There's no way to test a coverity fix right now. I have to land it and wait for the next coverity build to confirm. Andreas, given that, are you ok to land this patch as is?
yeah, it will work!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cf707f5b0477 Silence unused returned value warning and initialize the counter. r=pehrsons
I confirmed that the issue is marked as fixed by coverity. Thanks!
Status: RESOLVED → VERIFIED
Thanks for looking at it Sylvestre!
You need to log in before you can comment on or make changes to this bug.