1499635 - Support step attribute for time and datetime-local inputs (for second precision)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Rob Wu [:robwu]]

datetime-local and time inputs default to a precision of one minute. The step attribute can be used to change the precision to seconds (and even milliseconds...), but the UI does not offer a way to input seconds.

In bug 1498787, this bug was fixed on Fennec (for seconds only, not for milliseconds). In GeckoView, the bug is still present, as it uses different code to show UI for date/time input:
https://phabricator.services.mozilla.com/D8667#209324

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1499635 - Add step attribute value to DateTimePrompt. r=#geckoview-reviewers

We should add stepValue to DateTimePrompt to support step attribute such as
<input type="date" step="10"> etc in GeckoView.

Also, we don't have any tests for max/min attribute, so we should add it too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb766ad8a80e
Add step attribute value to DateTimePrompt. r=geckoview-reviewers,agi,calu

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eb766ad8a80e

Comment 5

[Chris Peterson [:cpeterson]]

This is a longstanding bug so no need to uplift this fix to Beta 101.