Closed Bug 1499706 Opened 2 years ago Closed 2 years ago

Make TabsInTitlebar.update private

Categories

(Firefox :: Tabbed Browser, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: mconley, Assigned: dao)

References

Details

Attachments

(1 file)

In bug 1356920, browser-tabsintitlebar.js and a bunch of our CSS was refactored to move a bunch of layout calculations out from JS and into our layout engine. We suspect that TabsInTitlebar.update no longer needs to be public, and that we can stop calling it from browser-fullScreenAndPointerLock.js.

I tried to do this in bug 1356920, but hit this weird state in the browser screenshots suite:

https://screenshots.mattn.ca/comparisons/try/b353994a94138de59232094fc8da7d7916ca53f1/try/8623452e62dafb1c9c38b91de1b0ec4b49e2a82f/windows10-64/primaryUI_273_tabsOutsideTitlebar_fiveTabs_maximized_onlyNavBar_noLWT_touchDensity.png

It looks like there is a case where making TabsInTitlebar private and removing the call from browser-fullScreenAndPointerLock.js is breaking how we disable TabsInTitlebar in the screenshots suite. We should figure that out, and then get TabsInTitlebar.update made private.
Assignee: nobody → dao+bmo
Priority: -- → P2
See Also: → 1173768, 1448613
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7d37169919d
Remove external calls to TabsInTitlebar.update and make it private. r=mconley
https://hg.mozilla.org/mozilla-central/rev/a7d37169919d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.