Make TabsInTitlebar.update private

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: mconley, Assigned: dao)

Tracking

unspecified
Firefox 65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
In bug 1356920, browser-tabsintitlebar.js and a bunch of our CSS was refactored to move a bunch of layout calculations out from JS and into our layout engine. We suspect that TabsInTitlebar.update no longer needs to be public, and that we can stop calling it from browser-fullScreenAndPointerLock.js.

I tried to do this in bug 1356920, but hit this weird state in the browser screenshots suite:

https://screenshots.mattn.ca/comparisons/try/b353994a94138de59232094fc8da7d7916ca53f1/try/8623452e62dafb1c9c38b91de1b0ec4b49e2a82f/windows10-64/primaryUI_273_tabsOutsideTitlebar_fiveTabs_maximized_onlyNavBar_noLWT_touchDensity.png

It looks like there is a case where making TabsInTitlebar private and removing the call from browser-fullScreenAndPointerLock.js is breaking how we disable TabsInTitlebar in the screenshots suite. We should figure that out, and then get TabsInTitlebar.update made private.
(Assignee)

Updated

5 months ago
Assignee: nobody → dao+bmo
Priority: -- → P2
(Assignee)

Updated

5 months ago
See Also: → bug 1173768, bug 1448613

Comment 3

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7d37169919d
Remove external calls to TabsInTitlebar.update and make it private. r=mconley

Comment 4

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a7d37169919d
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.