Closed
Bug 1499809
Opened 6 years ago
Closed 6 years ago
l10n bumper should touch a file on success
Categories
(Release Engineering :: Release Automation: L10N, enhancement)
Release Engineering
Release Automation: L10N
Tracking
(firefox-esr60 fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | fixed |
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(2 files)
On a noop, or on a successful push, we should touch a status file. (If we were unable to push an l10n-changesets change when there are dashboard changes, we should skip touching the status file.) Then we should change the nagios check to look at the age of the status file.
_ write in-tree l10n_bumper.py change to touch the status file
_ review
_ land
_ write puppet patch to use the new l10n_bumper.py revision
_ review
_ land
_ write nagios patch to switch the file to monitor
_ review
_ land
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
(We currently monitor the log file, which verifies that the previous hg operations aren't hung. However, that approach missed detecting bug 1499217; this approach should allow us to detect both.)
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0d593bf9772
l10n bumper should touch a status file on success. r=nthomas
Comment 4•6 years ago
|
||
bugherder |
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Should be fixed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•6 years ago
|
||
For posterity: 91ce935e2c..676a75e012 master -> master
Updated•6 years ago
|
Keywords: leave-open
Comment 8•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
Comment 9•6 years ago
|
||
I confirmed that this is indeed fixed on IT puppet:
commit 676a75e012ff8a7d871d5820ed61a4c9a4e61853
Author: Aki Sasaki <aki@escapewindow.com>
Date: Fri Oct 19 11:43:40 2018 -0700
Bug 1499809 - l10n bumper should touch a status file on success.
and:
@nagios1.private.releng.mdc1 ~]$ sudo grep -R l10n_bumper_status /etc/nagios/*
/etc/nagios/mozilla/services.cfg: check_command check_file_age!5400!7200!/builds/l10n-bumper/.l10n_bumper_status
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•