Closed Bug 1499958 Opened 6 years ago Closed 6 years ago

Green up wpt mathml directory on fennec

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(1 file)

One failure:

/mathml/presentation-markup/scripts/underover-1.html
  FAIL Height of scripted elements - assert_approx_equals: munderover 0: height is determined by the sum heights of base and scripts expected 33 +/- 3 but got 36.19999694824219
runTests/<@http://web-platform.test:8000/mathml/presentation-markup/scripts/underover-1.html:83:9
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20
test@http://web-platform.test:8000/resources/testharness.js:544:21
runTests@http://web-platform.test:8000/mathml/presentation-markup/scripts/underover-1.html:76:5
From my email with James:
> * The mathml one I think I've seen fail on desktop

I don't see a bug filed for it (there was an intermittent failure in underover-1.html with webrender a few months back, but that's since been fixed.

I ran this test 20 times and it failed every time, consistently coming in at 36.19999694824219.

Should we just mark this failing on Fennec and move on, or should we adjust the epsilon value at https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/testing/web-platform/tests/mathml/presentation-markup/scripts/underover-1.html#77 from 3 to 3.2, which would let the test pass on Android? 

Or would this be an actual bug that needs fixed on Fennec?
Flags: needinfo?(james)
Assignee: nobody → wkocher
I forwarded the review to emilio who has worked on MathML recently, in the hope he can verify that this change is sensible.
Flags: needinfo?(james)
Pushed by wkocher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/404f31aecd13
Increase epsilon value for comparisons in underover-1.html r=emilio
https://hg.mozilla.org/mozilla-central/rev/404f31aecd13
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13833 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: