Open Bug 1500046 Opened 6 years ago Updated 2 years ago

Intermittent devtools/client/inspector/animation/test/browser_animation_logic_mutations_fast.js | Test timed out -

Categories

(DevTools :: Inspector: Animations, defect, P5)

Product:
DevTools
Component:
Inspector: Animations
Type:
defect

Tracking

(Not tracked)

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [retriggered][stockwell disabled])

Attachments

(3 files)

Disabled on all platforms
797 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Bug 1500046 - fix intermittent timeout in animations_mutation_fast; r=daisuke
47 bytes, text/x-phabricator-request
Details | Review
Bug 1500046 - re-enable test; r=daisuke
47 bytes, text/x-phabricator-request
Details | Review
Filed by: btara [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=206323065&repo=autoland https://queue.taskcluster.net/v1/task/EOpkmMNbQsWlBxrb0Beq2w/runs/0/artifacts/public/logs/live_backing.log 10:30:00 INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/inspector/animation/test/doc_frame_script.js 10:30:00 INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/shared/test/frame-script-utils.js 10:30:00 INFO - Opening the inspector 10:30:00 INFO - Opening the toolbox 10:30:00 INFO - Buffered messages logged at 10:28:32 10:30:00 INFO - Toolbox opened and focused 10:30:00 INFO - Selecting the animationinspector sidebar 10:30:00 INFO - Check state of the animation inspector after fast mutations 10:30:00 INFO - Buffered messages logged at 10:28:37 10:30:00 INFO - TEST-PASS | devtools/client/inspector/animation/test/browser_animation_logic_mutations_fast.js | Animation inspector should be live - 10:30:00 INFO - Buffered messages finished 10:30:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/animation/test/browser_animation_logic_mutations_fast.js | Test timed out - 10:30:01 INFO - GECKO(5064) | ++DOMWINDOW == 28 (0B2AFC00) [pid = 5144] [serial = 134] [outer = 0B25AC60] 10:30:01 INFO - Removing tab. 10:30:01 INFO - Waiting for event: 'TabClose' on [object XULElement]. 10:30:01 INFO - Got event: 'TabClose' on [object XULElement]. 10:30:01 INFO - Tab removed and finished closing 10:30:01 INFO - GECKO(5064) | --DOCSHELL 15DE5400 == 11 [pid = 5144] [id = {e682ead2-aa1f-4ab0-b8e0-28c3c9a4bee9}] 10:30:01 INFO - GECKO(5064) | --DOCSHELL 15DE8400 == 10 [pid = 5144] [id = {bfd19eb1-3724-498d-92cf-537a09920807}] 10:30:01 INFO - GECKO(5064) | --DOMWINDOW == 27 (16ACA970) [pid = 5144] [serial = 128] [outer = 00000000] [url = about:blank]
Blocks: 1488379
Summary: Intermittent Test Verify devtools/client/inspector/animation/test/browser_animation_logic_mutations_fast.js | Test timed out - → Intermittent devtools/client/inspector/animation/test/browser_animation_logic_mutations_fast.js | Test timed out -
Created a disable patch for all platforms, in case if ti is needed.
Assignee: nobody → aiakab
Attachment #9019531 - Flags: review?(jmaher)
Comment on attachment 9019531 [details] [diff] [review] Disabled on all platforms Review of attachment 9019531 [details] [diff] [review]: ----------------------------------------------------------------- as this is disable recommended, lets do that- it is easy to re-enable the test when the devtools team has time to hack on it.
Attachment #9019531 - Flags: review?(jmaher) → review+
Keywords: checkin-needed, leave-open
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]
Hi, sorry it looks like I didn’t save my pto info in bugzilla. I will take a look at this next week when I am back. A bit of context - the intermittent in this test is due to how the test was originally written. It didn’t wait for shut down. When I made the change in the 1478839 bug, it properly shut down the animations front, causing the test to permafail. I introduced code that counts down until all of the code is finished running before shutting down, and this is likely the source of the intermittent. This was the second patch in that bug.
Flags: needinfo?(ystartsev)
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1aa6481a987a disabled browser_animation_logic_mutations_fast.js on all platforms. r=jmaher
Keywords: checkin-needed
It looks like my attempt to wait for everything to finish caused a more serious intermittent. I rolled back those changes here, but the updateAnimations function should be throttled, it is causing react to throw Invariant errors, as setState is called too many times too quickly.
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63fc6e8dea67 fix intermittent timeout in animations_mutation_fast; r=daisuke
Flags: needinfo?(ystartsev)
Please also see this dt failure that seems to be related to you push: https://treeherder.mozilla.org/logviewer.html#?job_id=208580945&repo=autoland&lineNumber=10069 Thanks!
Depends on D10048
yulia: Hi, this crash also started from the push that was backed out:https://treeherder.mozilla.org/logviewer.html#?job_id=208580995&repo=autoland&lineNumber=4825 I filed this bug for the crash https://bugzilla.mozilla.org/show_bug.cgi?id=1503226. Can you please have a look at it? Thanks!
See Also: → 1503226
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3223e196cc6e fix intermittent timeout in animations_mutation_fast; r=daisuke
I don't think that failure is related. With the two prs for this intermittent, it does not appear: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=208844684&revision=73cab44e90a6640839ed8713afe38c5c9e0d38ba
Flags: needinfo?(ystartsev)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: