Closed Bug 1500124 Opened 7 years ago Closed 7 years ago

Insufficient gating for struct operations in baseline compiler

Categories

(Core :: JavaScript: WebAssembly, enhancement, P2)

enhancement

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: lth, Assigned: lth)

Details

I don't think this really matters, but in principle the instruction decoder in the baseline compiler either needs to guard on the GC feature, like the decoder in the verifier does, or the checks that are in the verifier's decoder should move into the instruction readers. (The latter is the best choice.) Since the struct instructions always need ref types and ref types should be properly gated we're probably not at risk of anything. Anyway it's a moot point since the gc enablement switches are going away, but until then, this is technically a bug.
Weirdly, this looks like it's been fixed.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.