1500208 - Update Fastblock Prefs in Nightly/Beta (Disable FB)

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Tony Cinotto [:tcinotto] (UTC-8)]

For beta and nightly, remove all UI around fastblock and turn the feature off by default:
browser.contentblocking.fastblock.ui.enabled  = false
browser.contentblocking.fastblock.control-center.ui.enabled = false
browser.fastblock.enabled = false

For beta, no global toggle.  (This requires no change, its already off in beta):
browser.contentblocking.global-toggle.enabled = false

For Nightly, keep the global toggle (this requires no change, it is already on in nightly):
browser.contentblocking.global-toggle.enabled = true

Comment 1

[(no longer active)]

Please remember to update https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/browser/base/content/test/trackingUI/browser_trackingUI_telemetry.js#43 too.

Comment 2

[François Marier [:francois]]

Also, let's remove the special-case for beta/release here: https://searchfox.org/mozilla-central/rev/c56977420df7a1b692ce0f7e499ddb364d9fd7b2/modules/libpref/init/all.js#5913-5917

and have a single "pref("browser.fastblock.limit", 20000);".

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1500208 - Disable FastBlock, hide FastBlock UI everywhere. r=Ehsan,francois

Comment 4

[Johann Hofmann [:johannh]]

Try runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63655dbf2750696d421f05b954c278cd4535b50f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2ee8c92578c9f7240c42a6e98d31a0cf729ea88

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e62b3523fb5
Disable FastBlock, hide FastBlock UI everywhere. r=francois,Ehsan

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3e62b3523fb5

Comment 7

[Daniel]

Could someone please share some details on why this was disabled and removed from the Firefox roadmap?

Comment 8

[(no longer active)]

(In reply to Daniel from comment #7)
> Could someone please share some details on why this was disabled and removed
> from the Firefox roadmap?

See https://blog.mozilla.org/futurereleases/2018/10/23/the-path-to-enhanced-tracking-protection/, the part titled "Sometimes plans change – that’s why we test"...