Use toolkit.asyncshutdown.crash_timout as shutdown monitor base value

RESOLVED FIXED in Firefox 64

Status

enhancement
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

(Blocks 1 bug)

Trunk
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(2 attachments)

This bug is similar to bug 1443922 which is for geckodriver.

Marionette is currently hard-coded with a 70 second wait before
forcefully killing the Firefox process.  This is adequate for regular
optimised and debug builds, but the base value for ASAN is longer, and can be retrieved from the toolkit.asyncshutdown.crash_timeout preference.

This value should basically be used as shutdown timeout for Marionette client.

As already proposed on the other bug for geckodriver we should transfer this value when creating a new session as part of a vendor specific value.

I suggest that we fix this bug first for Marionette server, and client, and follow-up with geckodriver afterward.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Firefox uses different shutdown timeouts for the terminator thread
depending on the build type. For opt/debug builds this will be 60s,
while for ASAN builds 180s are used.

Currently Marionette only takes the 60s into account, and always
kills the binary after 70s if a shutdown hasn't happened by that
time. This actually prevents the background hang monitor to kill
Firefox for ASAN builds, and to report a meaningful crash report
for the shutdown hang.

To inform clients about the correct shutdown timeout, a new vendor
specific capability with the name `moz:shutdownTimeout` is used as
part of the new session capabilities.

Depends on D9227

Comment 4

7 months ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9645a734546b
[marionette] Don't modify DEFAULT_SHUTDOWN_TIMEOUT constant. r=ato
https://hg.mozilla.org/integration/autoland/rev/9a2be0efbc4c
[marionette] Obey the extended shutdown timeout for Firefox ASAN builds. r=ato

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9645a734546b
https://hg.mozilla.org/mozilla-central/rev/9a2be0efbc4c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.