1500242 - Use toolkit.asyncshutdown.crash_timout as shutdown monitor base value

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug is similar to bug 1443922 which is for geckodriver.

Marionette is currently hard-coded with a 70 second wait before
forcefully killing the Firefox process.  This is adequate for regular
optimised and debug builds, but the base value for ASAN is longer, and can be retrieved from the toolkit.asyncshutdown.crash_timeout preference.

This value should basically be used as shutdown timeout for Marionette client.

As already proposed on the other bug for geckodriver we should transfer this value when creating a new session as part of a vendor specific value.

I suggest that we fix this bug first for Marionette server, and client, and follow-up with geckodriver afterward.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1500242 - [marionette] Don't modify DEFAULT_SHUTDOWN_TIMEOUT constant. r?ato

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1500242 - [marionette] Obey the extended shutdown timeout for Firefox ASAN builds. r?ato

Firefox uses different shutdown timeouts for the terminator thread
depending on the build type. For opt/debug builds this will be 60s,
while for ASAN builds 180s are used.

Currently Marionette only takes the 60s into account, and always
kills the binary after 70s if a shutdown hasn't happened by that
time. This actually prevents the background hang monitor to kill
Firefox for ASAN builds, and to report a meaningful crash report
for the shutdown hang.

To inform clients about the correct shutdown timeout, a new vendor
specific capability with the name `moz:shutdownTimeout` is used as
part of the new session capabilities.

Depends on D9227

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d9c9a61311fa15cffaf92c2afc984e7c17bcf7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9645a734546b
[marionette] Don't modify DEFAULT_SHUTDOWN_TIMEOUT constant. r=ato
https://hg.mozilla.org/integration/autoland/rev/9a2be0efbc4c
[marionette] Obey the extended shutdown timeout for Firefox ASAN builds. r=ato

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9645a734546b
https://hg.mozilla.org/mozilla-central/rev/9a2be0efbc4c