1500320 - browser.omnibox doesn't support special characters, specifically forward slash (/) in keyword like Chrome does.

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P3)

Description

[sean.thomas.burke]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

I added the keyword "go/" to the "browser.omnibox" value in the manifest.json.


Actual results:

Firefox throws an error when trying to load the manifest file.
"There was an error during installation: Extension is invalid"


Expected results:

I would expect the keyword "go/" to compile in the manifest.json without errors, and for Firefox to trigger omnibox search when this keyword is entered. This currently works in Chrome, but does not work in Firefox.

Comment 1

[Caitlin Neiman [:caitmuenster]]

If this is your first contribution, please see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp for how to get started. 

Mentor: Rob Wu

Comment 2

[sean.thomas.burke]

Hi Rob, I would like to take on this bug.

Comment 3

[Caitlin Neiman [:caitmuenster]]

Hey Sean! I just assigned you to this bug. Feel free to needinfo Rob if you need any help!

Comment 4

[sean.thomas.burke]

Attachment: Updating the omnibox keyword regex to allow trailing slashes

Previously the omnibox keyword would not allow trailing slashes, such as go/
Chrome allows this keyword, and Firefox should allow this too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3417713c053
Updating the omnibox keyword regex to allow trailing slashes r=robwu,aswan

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f3417713c053

Comment 7

[Caitlin Neiman [:caitmuenster]]

Thanks for the patch, Sean! Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

Comment 8

[CosminB]

Attachment: Bug1500320.png

I was able to reproduce this issue on Firefox 63.0.3(20181114214635) under Win 7 64-bit and  Mac OS X 10.13.6.

This issue is verified as fixed on Firefox 65.0a1(20181205102000) under Win 7 64-bit and Mac OS X 10.13.6.

Please see the attached screenshot.