Closed Bug 1500360 Opened 2 years ago Closed 2 years ago

Add telemetry to record per download result in download protection


(Toolkit :: Safe Browsing, enhancement, P2)




Tracking Status
firefox65 --- fixed


(Reporter: dimi, Assigned: dimi)


(Blocks 1 open bug)



(3 files, 1 obsolete file)

We need a per download result in download protection to help us know what could we improve next. It will be also useful to see if there is anything unusual.

For example, by retrieving the information, we could understand the priority of Bug 1356426 better (See Bug 1356246 Comment 2).
Priority: -- → P2
Attached patch WIP patch (obsolete) — Splinter Review
Attachment #9019033 - Attachment is obsolete: true
In this patch, we added a telemetry to record different reasons that
why download protection service decides to allow or block this download.

The |verdict| and |shouldBlock| parameters are moved inside
PendingLookup::OnComplete and now we used |Reason| in the query
reputation code path instead

Use enumerated Telemetry because it is easier to add more reasons in the
Add "Reason" checks in the testcase because it provides more
fine-grained check.

In this patch, I also refactor the testcase by move telemetry stuff
into head_download_manager.js so it could easily used by different testcases.
Attachment #9024419 - Flags: review?(francois)
Comment on attachment 9024419 [details]

> 8) If this data collection is default on, what is the opt-out mechanism for users?
> I'm not aware of what the opt-out mechanisms are for data collection in Firefox

Users can turn off telemetry.
Comment on attachment 9024419 [details]

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Dimi Lee.

4) Using the **[category system of data types](** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?


7) Is the data collection covered by the existing Firefox privacy notice?


8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.
Attachment #9024419 - Flags: review?(francois) → review+
Pushed by
P1. Add telemetry to record the reason download protection allow or block the download. r=francois
P2. Use reason in download protection testcases. r=francois
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.