Closed Bug 1500416 Opened 5 years ago Closed 5 years ago

Dynamic insertion of display: contents elements doesn't work.

Categories

(Core :: Disability Access APIs, enhancement, P2)

Product:
Core
Component:
Disability Access APIs
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1500416 - Account for display: contents in ScheduleContentInsertion.
46 bytes, text/x-phabricator-request
Details | Review 
The check in here:

  https://searchfox.org/mozilla-central/rev/c56977420df7a1b692ce0f7e499ddb364d9fd7b2/accessible/base/NotificationController.cpp#432

Doesn't work for display: contents elements, which don't have a frame.

So that check probably needs to be extended to handle display: contents as well.

Should be reproducible inserting something like <ul style="display: contents"> dynamically.
Thanks for catching. Confirmed:
data:text/html,<div id="div"></div><button onClick="div.innerHTML = `<ul style='display: contents;'><li>1</li></ul>`;">Add</button>
When the Add button is pressed, you see the "1" text in the accessibility tree, but no accessible for the list.
Priority: -- → P2
Summary: Dynamic insertion of display: contents elements probably doesn't work. → Dynamic insertion of display: contents elements doesn't work.
Assignee: nobody → emilio
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d15bcd82f19d
Account for display: contents in ScheduleContentInsertion. r=Jamie
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd985440b6e2
Fixup to avoid triggering the trailing commas lint on a CLOSED TREE.
You need to log in before you can comment on or make changes to this bug.