Closed Bug 1500467 Opened Last year Closed Last year

Annotate profiling labels which are JavaScript entry and exit points

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(4 files)

This is the Gecko side of https://github.com/devtools-html/perf.html/issues/1392 .

Proposal: Add a new column to the frameTable called "relevantForJS" which contains true or false for each frame. Set it to true for AutoScriptEntry frames and WebIDL API frames.

Greg, does this format change sound good to you?
Flags: needinfo?(gtatum)
Depends on: 1499507
Assignee: nobody → mstange
Status: NEW → ASSIGNED
It sounds like a good plan to me.
Flags: needinfo?(gtatum)
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/9601c8af6d8d
Add RELEVANT_FOR_JS flag and update profile format with an extra relevantForJS column in the stack table. r=njn
https://hg.mozilla.org/integration/autoland/rev/26a850e26e27
Mark WebIDL profiler label frames as RELEVANT_FOR_JS. r=njn
https://hg.mozilla.org/integration/autoland/rev/74eb25707025
Mark AutoEntryScript label frames as RELEVANT_FOR_JS. r=njn
https://hg.mozilla.org/integration/autoland/rev/a7df15c51806
Mark stack labels for JS built-ins as RELEVANT_FOR_JS. r=njn
You need to log in before you can comment on or make changes to this bug.