1500467 - Annotate profiling labels which are JavaScript entry and exit points

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Markus Stange [:mstange]]

This is the Gecko side of https://github.com/devtools-html/perf.html/issues/1392 .

Proposal: Add a new column to the frameTable called "relevantForJS" which contains true or false for each frame. Set it to true for AutoScriptEntry frames and WebIDL API frames.

Greg, does this format change sound good to you?

Comment 1

[Greg Tatum [:gregtatum]]

It sounds like a good plan to me.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1500467 - Add RELEVANT_FOR_JS flag and update profile format with an extra relevantForJS column in the stack table. r?njn

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1500467 - Mark WebIDL profiler label frames as RELEVANT_FOR_JS. r?njn

Depends on D9300

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1500467 - Mark AutoEntryScript label frames as RELEVANT_FOR_JS. r?njn

Depends on D9301

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1500467 - Mark stack labels for JS built-ins as RELEVANT_FOR_JS. r?njn

Depends on D9302

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9601c8af6d8d
Add RELEVANT_FOR_JS flag and update profile format with an extra relevantForJS column in the stack table. r=njn
https://hg.mozilla.org/integration/autoland/rev/26a850e26e27
Mark WebIDL profiler label frames as RELEVANT_FOR_JS. r=njn
https://hg.mozilla.org/integration/autoland/rev/74eb25707025
Mark AutoEntryScript label frames as RELEVANT_FOR_JS. r=njn
https://hg.mozilla.org/integration/autoland/rev/a7df15c51806
Mark stack labels for JS built-ins as RELEVANT_FOR_JS. r=njn

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9601c8af6d8d
https://hg.mozilla.org/mozilla-central/rev/26a850e26e27
https://hg.mozilla.org/mozilla-central/rev/74eb25707025
https://hg.mozilla.org/mozilla-central/rev/a7df15c51806