Can we do better than blob images for some clip-paths?

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(2 attachments)

Bug 1500300 triggers a giant blob image as an image mask because the container has a fixed-position child underneath.

However it looks to me like we ough to be able to push a clip rect instead of a blob image, since the page is only using the inset() function.

I'm not familiar with all the clip-path setup in order to know whether the current behavior is just suboptimal or needed for correctness in some cases.

Markus, does the above sound reasonable?
Assignee

Comment 1

8 months ago
(See comment 0)
Flags: needinfo?(mstange)
Assignee

Comment 2

8 months ago
Also, https://christopher-tierney.com/apotheke-la/ is a real-world page that would trigger this... I guess we should first measure once I get the tiled mask images landed.
It would be very valuable to optimize inset() clip paths into rectangle clips. There should be no difference from a correctness perspective. (It's possible that we currently don't pixel-snap inset() clips, so they might have blurry edges, but that's not a desirable result anyway.)
Flags: needinfo?(mstange)
Assignee

Comment 4

8 months ago
(Just so it doesn't fall of my radar)
Flags: needinfo?(emilio)
Assignee

Comment 6

8 months ago
Posted file Testcase
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Assignee

Updated

8 months ago
Flags: needinfo?(emilio)
Attachment #9019069 - Attachment description: Bug 1500575 - [WIP] Map inset clip paths to WR complex clip regions. → Bug 1500575 - Map inset clip paths to WR complex clip regions.

Comment 7

8 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/9140cba9a8f8
Map inset clip paths to WR complex clip regions. r=kats
Assignee

Updated

8 months ago
Flags: needinfo?(emilio)
Assignee

Updated

8 months ago
Blocks: 1501122
Assignee

Updated

8 months ago
Blocks: 1501125

Comment 8

8 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/bebe2e4eab25
De-fuzz another webrender test. r=me

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9140cba9a8f8
https://hg.mozilla.org/mozilla-central/rev/bebe2e4eab25
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.