1500596 - implement first audio decoder (vorbis) in RDD

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Michael Froman [:mjf]]

After RDD lands with av1, we should implement the first remote audio decoder, probably vorbis.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1500596 - pt1 - modify IPC sync message name for making remote decoders. r?jld!

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1500596 - pt2 - Add operator== for AudioInfo and VideoInfo. r?jya!

These are needed for upcoming addition to an IPDL union.

Depends on D18639

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1500596 - pt3 - Add remote audio decoding for Vorbis. r?jya!

• Use a single remote decoder IPDL spec and make a remote decoding
  base class.
  Renames PRemoteVideoDecoder.ipdl to PRemoteDecoder.ipdl
  Renames RemoteVideoDecoder{Child|Parent}.{cpp|h} to
  RemoteDecoder{Child|Parent}.{cpp|h}

• Move remote video decoding to new subclasses.
  Creates RemoteVideoDecoder.{cpp|h} that contains both the parent
  and child sides of the RemoteVideoDecoder{Child|Parent} classes.

• Create new remote audio decoder
  Creates RemoteAudioDecoder.{cpp|h} that contains both the parent
  and child sides of the RemoteAudioDecoder{Child|Parent} classes.

• Connect all the plumbing to use the new remote audio decoder to
  decode Vorbis in RDD including a new pref to control whether
  Vorbis is decoding in the AgnosticDecoderModule or the
  RemoteDecoderModule/RDD (media.rdd-vorbis.enabled).

Depends on D18640

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cce258ac041b
pt1 - modify IPC sync message name for making remote decoders. r=jld
https://hg.mozilla.org/integration/autoland/rev/c1648a2a4d08
pt2 - Add operator== for AudioInfo and VideoInfo. r=jya
https://hg.mozilla.org/integration/autoland/rev/3699bea870c4
pt3 - Add remote audio decoding for Vorbis. r=jya

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cce258ac041b
https://hg.mozilla.org/mozilla-central/rev/c1648a2a4d08
https://hg.mozilla.org/mozilla-central/rev/3699bea870c4

Comment 6

[Michael Froman [:mjf]]

This bug doesn't really depend on 1538474.