Closed Bug 1500735 Opened 2 years ago Closed 2 years ago

Update cached-iterable in Fluent to 0.3.0

Categories

(Core :: Internationalization, defect, P1)

Product:
Core
Component:
Internationalization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 + fixed
firefox65 + fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1500735 - Update cached-iterable in Fluent to 0.3.0.
46 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review 
In bug 1498960 I accidentally regressed cached-iterable because to 0.2.1.

I released 0.3.0 now - https://github.com/projectfluent/cached-iterable/releases/tag/v0.3.0 - which contains the patch that we used before.

I'm going to push this patch with r=me to revert the regression.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c8bbe5f25a7
Update cached-iterable in Fluent to 0.3.0. r=stas
https://hg.mozilla.org/mozilla-central/rev/6c8bbe5f25a7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9018858 [details]
Bug 1500735 - Update cached-iterable in Fluent to 0.3.0.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498960

User impact if declined: Potential race condition when localization gets initialized.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a minor regression that I introduced when landing 0.9.

String changes made/needed: none
Attachment #9018858 - Flags: approval-mozilla-beta?
Blocks: 1498960
status-firefox63: --- → unaffected
status-firefox64: --- → affected
status-firefox-esr60: --- → unaffected
tracking-firefox64: --- → +
tracking-firefox65: --- → +
Flags: qe-verify-
Flags: in-testsuite-
Keywords: regression
Comment on attachment 9018858 [details]
Bug 1500735 - Update cached-iterable in Fluent to 0.3.0.

Reverts an accidentally downgrade of cached-iterable from the Fluent 0.9 update landed in Fx64. Approved for 64.0b4.
Attachment #9018858 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.