1500885 - mTextAlignTrue / mTextAlignLastTrue are write-only.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1500885 - mTextAlignTrue / mTextAlingLastTrue are write-only.

They were added in bug 929991, but there's no text-align: true anymore.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1500885 - Serialize text-align with Servo.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think 'true' has been renamed to 'unsafe' at https://drafts.csswg.org/css-align-3/#overflow-values .  Also see bug 969106.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

And also see bug 1237059.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(and this is really a duplicate of the latter)

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I think that given we no longer have style system support for this at all (since bug 1388949 was never fixed), and that the implementation is relatively simple, we should just remove it for now.

Comment 7

[Mats Palmgren (inactive)]

I think it's fine to remove it for now.
Neither css-text-3/4 mentions true/unsafe anymore.
https://drafts.csswg.org/css-text-3/#text-align-property
https://drafts.csswg.org/css-text-4/#text-align-property

Comment 8

[Emilio Cobos Álvarez [:emilio]]

(for the second bit)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a97be306a98
mTextAlignTrue / mTextAlingLastTrue are write-only. r=mats

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1500885 - Remove tests and other similar bits.

Also remove specified-value-only keywords, since those are handled
only in Rust code and C++ doesn't need to know about them.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35c3b881583a
Serialize text-align with Servo. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/0dac7f40ea5f
Remove some unused keywords. r=xidorn

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9a97be306a98

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/35c3b881583a
https://hg.mozilla.org/mozilla-central/rev/0dac7f40ea5f

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ddf191431a9
Remove tests and other similar bits. r=mats

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5ddf191431a9