Closed
Bug 1500885
Opened 6 years ago
Closed 6 years ago
mTextAlignTrue / mTextAlignLastTrue are write-only.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
They were added in bug 929991, but there's no text-align: true anymore.
Assignee | ||
Comment 2•6 years ago
|
||
I think 'true' has been renamed to 'unsafe' at https://drafts.csswg.org/css-align-3/#overflow-values . Also see bug 969106.
Summary: mTextAlignTrue / mTextAlingLastTrue are write-only. → mTextAlignTrue / mTextAlignLastTrue are write-only.
And also see bug 1237059.
(and this is really a duplicate of the latter)
Assignee | ||
Comment 6•6 years ago
|
||
I think that given we no longer have style system support for this at all (since bug 1388949 was never fixed), and that the implementation is relatively simple, we should just remove it for now.
Comment 7•6 years ago
|
||
I think it's fine to remove it for now. Neither css-text-3/4 mentions true/unsafe anymore. https://drafts.csswg.org/css-text-3/#text-align-property https://drafts.csswg.org/css-text-4/#text-align-property
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/9a97be306a98 mTextAlignTrue / mTextAlingLastTrue are write-only. r=mats
Assignee | ||
Comment 10•6 years ago
|
||
Also remove specified-value-only keywords, since those are handled only in Rust code and C++ doesn't need to know about them.
Comment 11•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/35c3b881583a Serialize text-align with Servo. r=xidorn https://hg.mozilla.org/integration/autoland/rev/0dac7f40ea5f Remove some unused keywords. r=xidorn
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9a97be306a98
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/35c3b881583a https://hg.mozilla.org/mozilla-central/rev/0dac7f40ea5f
Comment 14•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/5ddf191431a9 Remove tests and other similar bits. r=mats
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ddf191431a9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•