1500941 - Add searchfox taskcluster job for Android

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

We have linux and mac taskcluster jobs enabled. Windows is being tracked in bug 1418415. We should add Android to round out the set.

Last time I tried this I ran into something that looked similar to bug 1418364.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I got past the error I was having before, but now there's a mangling failure in clang when processing one of the headers in the NDK. I see it on try but not locally. https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=228798530&revision=57dfd32fff9fbd513704ce9461b4e32b6a103b8a

Very similar in some respects to what we ran into on Windows - https://bugs.llvm.org/show_bug.cgi?id=39294. Will probably have to add a patch to our clang build to work around this, like we did in bug 1418415.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The mangling failure in clang was a null pointer deref. Easy enough to work around, and I can follow up on the LLVM bug (in "see also" links) if they need help to fix it for reals.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=a88914483cc755c51a3a866305800860599d552a is the latest attempt which should have all the final patches. Fingers crossed.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Missed one env var. This one is better: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=b541d8eb8563812075a2973498140f70ffdbd1ff

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1500941 - Add a clang mangling crash workaround. r?dmajor

This is a workaround for https://bugs.llvm.org/show_bug.cgi?id=40747
where clang's mangler crashes when it tries to mangle a symbol from
the android NDK's <tuple> header.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1500941 - Add searchfox task for Android (ARMv7/API16). r?nalexander

The bulk of this is copy/pasted from a standard android-api-16 debug
build. The only changes are a few extra environment variables in the
taskcluster config, the subconfig file, and the mozconfig, as well as
the --enable-mozsearch-plugin flag in the mozconfig.

Depends on D20766

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1500941 - Enable Android searchfox job as part of the daily cron. r?emilio

Depends on D20767

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d6224e1d015
Add a clang mangling crash workaround. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/6e669b1b1835
Add searchfox task for Android (ARMv7/API16). r=nalexander
https://hg.mozilla.org/integration/autoland/rev/10ffd49d0adf
Enable Android searchfox job as part of the daily cron. r=emilio

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d6224e1d015
https://hg.mozilla.org/mozilla-central/rev/6e669b1b1835
https://hg.mozilla.org/mozilla-central/rev/10ffd49d0adf

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozsearch/mozsearch-mozilla/pull/29

Comment 10

[Kartikaya Gupta (email:[e-mail])]

This is deployed now